DL-1590: Update bidwon and bidtimeout pixels#28
Merged
JeremiePat merged 3 commits intosublime-adapterfrom Mar 18, 2021
Merged
Conversation
o3LL
suggested changes
Mar 15, 2021
o3LL
left a comment
o3LL
left a comment
There was a problem hiding this comment.
A part le petit ; de rien du tout, ça me semble good!
fgcloutier
approved these changes
Mar 15, 2021
o3LL
approved these changes
Mar 15, 2021
JeremiePat
force-pushed
the
DL-1590/update-bidwon-bidtimeout-pixels
branch
from
c7de09e to
d5d2709
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Update sublimeAdapter to version 0.7.1: We need more data in the pixels we send to better qualified our win.
How to test
See : https://github.com/SublimeSkinz/Emilbus/pull/3086 to understand how to use sskz_publishers to test the prebid.js build
Each time we win a bid, checkout the
bidwonpixels, it should have some new data:device,verandtimeoutThe same data should be send in case of a
bidtimeoutJIRA Ticket
https://sublimeskinz.atlassian.net/browse/DL-1590