Support horizontal/vertical fraction for auto_zoom_on_focus #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrade zoom_pane(self, auto_zoom) to support auto zoom in X and Y direction，Origami settings update:
// Automatically zoom the active pane.
// Set it to `true` for the default zoom, or to a user-definable
// fraction of the screen, such as "0.75" or [0.5, 0.7].
"auto_zoom_on_focus": [0.55, 0.75],
upgrade zoom_pane(self, auto_zoom) to support auto zoom in X and Y direction，Origami settings update: // Automatically zoom the active pane. // Set it to true for the default zoom, or to a user-definable // fraction of the screen, such as "0.75" or [0.5, 0.7]. "auto_zoom_on_focus": [0.55, 0.75],
rchl
requested changes
Sep 13, 2023
Member
rchl
left a comment
rchl
left a comment
There was a problem hiding this comment.
Missing an update of settings also.
You can have Origami automatically zoom the active pane by setting `auto_zoom_on_focus` in your Origami user preferences. Set it to `true` for the default zoom, or set it to a user-definable fraction of the screen, such as `0.75`, or `[0.5, 0.6]` for horitontal and vertical correspondingly.
rchl
reviewed
Sep 14, 2023
if you want to activate a pane when mouse on hover event, set `auto_focus_on_hover` to true in the Origami preferences.
…mouse on hover event, set `auto_focus_on_hover` to true in the Origami preferences.
rchl
reviewed
Sep 14, 2023
rchl
reviewed
Sep 15, 2023
Co-authored-by: Rafał Chłodnicki <rchl2k@gmail.com>
Co-authored-by: Rafał Chłodnicki <rchl2k@gmail.com>
rchl
reviewed
Sep 16, 2023
rchl
approved these changes
Sep 19, 2023
rchl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade zoom_pane(self, auto_zoom) to support auto zoom in X and Y direction，Origami settings update:
// Automatically zoom the active pane.
// Set it to true for the default zoom, or to a user-definable
// fraction of the screen, such as "0.75" or [0.5, 0.7].
"auto_zoom_on_focus": [0.55, 0.75],