Sunset syntax module #187
Open
Sunset syntax module #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR turns functions from sublime_lib.syntax module into aliases of sublime API calls and prints deprecation warnings when being called. ST4 provides compatible API calls, which can be used as drop-in replacement. This change assumes SyntaxInfo members are accessed in sane ways, which don't cause trouble by sublime.Syntax being a normal class. This change fixes a compatibility issue with python 3.13, as plistlib removed `readPlistFromBytes` function.
As SyntaxInfo is not exported, and #132 mentions returning `sublime.Syntax` directly, the type alias for it is removed.
Plump print as warnings.deprecated is not supported by python 3.8.
deathaxe
force-pushed
the
feat/sunset-syntax
branch
from
5627a50 to
7a9eba3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns functions from sublime_lib.syntax module into aliases of sublime API calls and prints deprecation warnings when being called.
ST4 provides compatible API calls, which can be used as drop-in replacement.
This change assumes SyntaxInfo members are accessed in sane ways, which don't cause trouble by sublime.Syntax being a normal class.
This change fixes a compatibility issue with python 3.13, as plistlib removed
readPlistFromBytesfunction.