Fully sync exosuits and drilling

[SpaceMonkeyy86]

• Sync claw arms
• Sync picking up items with claw arms
• Sync drill arms
• Sync drill arm position when drilling (automatically moves down to deposit)
• Sync grappling arms
• Sync grappling hook from grappling arms
• Sync propulsion arms
• Sync torpedo arms
• Sync exosuit power cells
• Sync drillable deposits visually disappearing in parts when drilled
• Sync resources spawning from drillable deposits
• Sync "pinata" resources automatically going into vehicle storage
• Sync respawning ion cube deposit in primary containment facility antechamber
• Persist destroyed status of deposits when saving

Fixes #2278, fixes #2303, fixes #2386, fixes #2577

[leonidasjan]

GJ on the PR @SpaceMonkeyy86

I found 4 bugs that u might have missed

1. The second power cell in the exosuit isn’t synced at all.

2. If you swap an arm from one slot to another, it first vanishes for everyone, then reappears—but only for the second player.

3. If you repeatedly equip and unequip an arm, it can sometimes duplicate (this might be just lag but i can do it consistently).

4. The other player can still hear some sounds from the exosuit when the other player is far away (like 0,5km away). When u let go of the spacebar, they can hear for split second the jetpack/engine "revving off". Occasionally they can also hear a loud stomp from the exosuit.

Everything else works great :D. Keep up the good work

[SpaceMonkeyy86]

@leonidasjan These should be fixed now. For the sound effects, that is not really relevant for this PR since the sound is synced, but it was probably designed to play regardless of world position, since you are normally right on top of it. We will get around to reworking those sounds sometime, though.

[leonidasjan]

Good work on the bug fixes @SpaceMonkeyy86 😄

The bugs i listed are gone (except for the sound issues but i understand that its for the future).

The only thing ive noticed is that there are still some bugs while grabbing another player with the hook. If you want u can fix those issues but IMO grabbing other players should be disabled cause its a little weird.

from the bug testing perspective the pr is almost ready to merge

[Measurity]

Claw arm items pickup isn't synced immediately with remote player but items are there on rejoin.

[SpaceMonkeyy86]

Fixed claw arm pickups, ready for review

[Jannify]

LGTM CW :D

[Jannify]

Does the pr also fix #2303 an #2386 ?

[SpaceMonkeyy86]

Found a bug that deletes modules from your inventory once you relog, need to fix before merge

[SpaceMonkeyy86]

Fixed.

Does the pr also fix #2303 an #2386 ?

Yes, module removal was reworked and doesn't cause log errors. It now uses a conservative approach where RemoveItem() destroys the entity and AddItem() respawns it, so it is possible to remove modules without putting them under another container now. That also fixes #2577 and probably also nuclear reactor rods not being consumed (not sure how to test that without going AFK for 80 minutes).

[Measurity]

💯