-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Refactor server to use .NET Generic Host APIs #2314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Measurity
wants to merge
42
commits into
SubnauticaNitrox:master
Choose a base branch
from
Measurity:server-net-host
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
Member
|
Seems like another huge piece of work and it will be hard to test/integrate. |
e86339e to
32e17bf
Compare
Test Results239 tests - 7 238 ✅ - 7 7s ⏱️ ±0s Results for commit 013ba52. ± Comparison against base commit aae4e50. This pull request removes 8 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
598fcfd to
467ebf3
Compare
a333b83 to
210277d
Compare
210277d to
3f27081
Compare
5348224 to
0ee1082
Compare
now it had stopped working for server console.
Now exception will be logged again under a log, if available
Added "(REDACTED)" tag to logged IPs if redacted.
Got accidentially removed during merge resolving
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: dev
Related to development environment or dev QoL
Area: server moderation
Related to managing server config and server player management
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NitroxConfigin custom MS configuration provider for validation, CMD args and DI supportNitrox.Model.Logger.Log(i.e. redaction andLogOnce).server.Development.jsonwhich allows developers to override any config property. It should be generated on build if it doesn't exist. And should work with instant launch too.Missing features
We should tell users to edit config file directly, and restart server. This is because
IOptions<T>from MSDI does not have persisting built-in.Reviewing
Everything flows from
Program.StartServerAsyncso I recommend giving it a good look before reviewing the rest.I tried to compartmentalize dependencies together into extension methods on
IServiceCollection. In other words, removing.AddPackets()should still compile and run the server. It just won't have any packet related services (like LiteNetLib) running.Issues to close
Preview