Tighten Re-encode video window progress layout#11112
Merged
Merged
Conversation
- Anchor the progress bar to the top of its cell so it doesn't drift down when the status text below grows the cell height. - Pad 5px above the bar and place the status text 10px below it. - Set MinWidth = 600 on the window and switch the outer column from Auto to Star so the content actually expands to that width. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the Avalonia UI layout for the Video → Re-encode video window to keep the progress area visually stable and ensure the window’s minimum width is reflected in its content layout.
Changes:
- Set
MinWidth = 600for the window to avoid overly narrow layouts. - Switch the outer grid column from
AutotoStarso content can stretch when the window is wider than its measured content. - Anchor the progress bar to the top of its cell and tweak margins to maintain consistent spacing between the bar and status text.
Comment on lines
160
to
169
| var progressBar = UiUtil.MakeProgressBar(); | ||
| progressBar.VerticalAlignment = VerticalAlignment.Top; | ||
| progressBar.Margin = new Thickness(0, 5, 0, 0); | ||
| progressBar.Bind(ProgressBar.ValueProperty, new Binding(nameof(vm.ProgressValue))); | ||
| progressBar.Bind(ProgressBar.IsVisibleProperty, new Binding(nameof(vm.IsGenerating))); | ||
|
|
||
| var statusText = new TextBlock | ||
| { | ||
| Margin = new Thickness(5, 20, 0, 0), | ||
| Margin = new Thickness(5, 25, 0, 0), | ||
| }; |
Replace the single-cell overlay (progress bar + status text with hard-coded top margins of 5 and 25) with two Auto rows separated by RowSpacing = 10. The 10px gap between the bar and the text is now intrinsic to the layout rather than computed from "statusText.Margin - progressBar.Height - progressBar.Margin", so changing the bar height or text font size no longer silently breaks the spacing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VerticalAlignment.Top) — the bar has explicitHeight=10and was drifting downward when the status-text cell grew.MinWidth = 600on the window and switch the outer column fromAutotoStarso the wider window actually expands the inner content instead of leaving empty space on the right.Test plan
🤖 Generated with Claude Code