Skip to content

Suppress cancel-error dialog in auto-translate #11113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niksedk merged 2 commits into from
May 23, 2026
+7 −1
Merged

Suppress cancel-error dialog in auto-translate #11113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95d4e34
Suppress cancel-error dialog in auto-translate
niksedk May 23, 2026
9ba5e52
Race-proof the auto-translate cancel guard
niksedk May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/ui/Features/Translate/AutoTranslateViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,8 +627,8 @@ private void Ok()
private void Cancel()
{
var wasTranslating = !IsTranslateEnabled;
_cancellationTokenSource.Cancel();
_abort = true;
_cancellationTokenSource.Cancel();
IsProgressEnabled = false;

if (IsTranslateEnabled)
Expand Down Expand Up @@ -1249,6 +1249,12 @@ private async Task DoTranslate(TranslationPair sourceLanguage, TranslationPair t
}

}
catch (OperationCanceledException) when (_abort || _cancellationTokenSource.IsCancellationRequested)
{
// User pressed Cancel — let the finally block report it; do not surface as an error.
// Check both _abort and the token: Cancel() sets _abort then fires the token, but the
// worker thread can observe cancellation before _abort is visible across threads.
}
catch (Exception ex)
{
_ = Dispatcher.UIThread.Invoke(async () =>
Expand Down