Merged
Conversation
Move test fixtures from manual mdbook builds to proper cargo tests. Add test-util feature flag to gate CheckCodePreprocessor test utilities so that the e2e tests can run without approval checking. All tests can be run with `cargo test --features test-util`.
Replace complex manual mdbook invocation with craneLib.cargoTest that runs `cargo test --features integration-tests`. This single check runs all tests (unit + integration) and properly handles both valid_cases and error_cases fixtures. Renamed from runE2ETests to mdbook-check-code-test for consistency with other check names.
Update workflow to use new check name mdbook-check-code-test instead of runE2ETests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move test fixtures from manual mdbook builds to proper cargo tests. Add test-util feature flag to gate CheckCodePreprocessor test utilities so that the e2e tests can run without approval checking.
All tests can be run with
cargo test --features test-util.