Added fix for updater#400
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a30199801b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (commandId === 'system-update-and-reopen') { | ||
| await window.electron.appUpdaterQuitAndInstall(); | ||
| try { await window.electron.hideWindow(); } catch {} | ||
| return true; |
There was a problem hiding this comment.
This new local handler always returns success for system-update-and-reopen and ignores the boolean returned by appUpdaterQuitAndInstall(). Since restartAndInstallAppUpdate() can now fail (timeout/error) and return false, launcher-triggered updates will still be treated as successful and the window is hidden without surfacing failure, which regresses user feedback and retry behavior for failed installs.
Useful? React with 👍 / 👎.
1 participant
No description provided.