Enhancements#404
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85b1508a98
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ] | ||
| } | ||
| ], | ||
| "target": "dmg", |
There was a problem hiding this comment.
Setting build.mac.target to only "dmg" removes the ZIP artifact that macOS auto-update flows depend on; this repo initializes electron-updater in src/main/main.ts (e.g. autoUpdater.checkForUpdates()), so packaged builds can advertise updates but fail to fetch/install them when only DMG assets are published. Keep a ZIP target (or default) alongside DMG for release builds.
Useful? React with 👍 / 👎.
| require('child_process').execFileSync( | ||
| '/usr/bin/osascript', | ||
| ['-e', 'tell application "System Events" to tell process "Dock" to get {position, size} of list 1'], | ||
| { encoding: 'utf8', timeout: 400 } |
There was a problem hiding this comment.
readMacDockFrame() uses synchronous execFileSync to run AppleScript, and this function is now on the window-management hotkey path via normalizeWindowManagementDisplayWorkArea(...) (used in fine-tune/layout command execution). On macOS systems where osascript is slow or times out, each resize command can stall the Electron main process for up to the configured timeout, causing visible lag/freeze while arranging windows.
Useful? React with 👍 / 👎.
1 participant
No description provided.