Skip to content

STYLE: Remove void from empty function parameter lists#571

Merged
N-Dekker merged 1 commit intodevelopfrom
Remove-void-from-empty-parameter-list
Jan 3, 2022
Merged

STYLE: Remove void from empty function parameter lists#571
N-Dekker merged 1 commit intodevelopfrom
Remove-void-from-empty-parameter-list

Conversation

@N-Dekker
Copy link
Copy Markdown
Member

Following ITK commit "STYLE: removing void if used in place of empty parameter list", by Dženan Zukić, 11 September 2018
InsightSoftwareConsortium/ITK@60807f4

And ITK commit "STYLE: Remove redundant void argument lists", by Hans Johnson, 20 February 2020
pull request InsightSoftwareConsortium/ITK#1628
InsightSoftwareConsortium/ITK@e6d859e

In accordance with C++ Core Guidelines, August 19, 2021: "Don't use void as an argument type"
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#nl25-dont-use-void-as-an-argument-type

Clang-Tidy "modernize-redundant-void-arg" check:
https://clang.llvm.org/extra/clang-tidy/checks/modernize-redundant-void-arg.html

@N-Dekker N-Dekker force-pushed the Remove-void-from-empty-parameter-list branch from 0e44771 to 37b4772 Compare December 30, 2021 21:30
Following ITK commit "STYLE: removing void if used in place of empty parameter list", by Dženan Zukić, 11 September 2018
InsightSoftwareConsortium/ITK@60807f4

And ITK commit "STYLE: Remove redundant void argument lists", by Hans Johnson, 20 February 2020
pull request InsightSoftwareConsortium/ITK#1628
InsightSoftwareConsortium/ITK@e6d859e

In accordance with C++ Core Guidelines, August 19, 2021: "Don't use void as an argument type"
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#nl25-dont-use-void-as-an-argument-type

Clang-Tidy "modernize-redundant-void-arg" check:
https://clang.llvm.org/extra/clang-tidy/checks/modernize-redundant-void-arg.html

Using Notepad++ v8.1.9.2, Find in Files (Filters: *.hxx;*.h;*.cxx [v] Match case):

    Find what: (void);
    Replace with: ();
    (*) Normal

    Find what: ( void )
    Replace with: ()
    (*) Normal

    Find what: (void)
    Replace with: ()
    (*) Normal

    Find what:   void)
    Replace with:   )
    (*) Normal

    Find what: (void)\r\n
    Replace with: ()\r\n
    (*) Extended
@N-Dekker N-Dekker force-pushed the Remove-void-from-empty-parameter-list branch from 37b4772 to 8eae8a8 Compare December 31, 2021 09:37
@N-Dekker N-Dekker changed the title STYLE: Remove void from empty function parameter list (void) STYLE: Remove void from empty function parameter lists Dec 31, 2021
@N-Dekker N-Dekker merged commit f8daf01 into develop Jan 3, 2022
@N-Dekker N-Dekker deleted the Remove-void-from-empty-parameter-list branch January 3, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant