Open
Conversation
oda
reviewed
Apr 28, 2024
| def combinationSum(self, candidates: List[int], target: int) -> List[List[int]]: | ||
| # 書くのが安定しているwhileで書く | ||
| combinations = [] | ||
| stack = [[[], 0, 0]] # current_combination, current_index, current_value |
oda
reviewed
Apr 28, 2024
| combinations = [] | ||
| stack = [[[], 0, 0]] # current_combination, current_index, current_value | ||
| while stack: | ||
| current_combination, current_index, current_value = stack.pop() |
There was a problem hiding this comment.
https://discord.com/channels/1084280443945353267/1225849404037009609/1232382815849414656
あたりでも話しているんですが、とにかく名前の付け方に抵抗感があります。
伝える意図が感じられません。
普段一文字で書いているのを、形式的に長くしたように感じています。
Owner
Author
|
combinations_of_sum_equals_targetの中身が数字のcombinationであることをより明確にするためにList[List[int]]を型ヒントしてみたのですがどうでしょうか |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題
https://leetcode.com/problems/combination-sum/description/?envType=list&envId=xo2bgr0r