Open
Conversation
Owner
Author
|
あ、phase2のところでorder -> digit 同じものを意味する言葉を混在させないとあるんですが, phase1を書いている途中で, 方針が合わないなと思って消してしまった別の関数を生やしていてその中でdigitという名前を使っていたので直したってだけです |
Owner
Author
|
あとphase3で急ぐあまりコメントをしてなかったですね。 |
Owner
Author
liquo-rice
reviewed
Apr 25, 2024
| @@ -0,0 +1,51 @@ | |||
| # Definition for singly-linked list. | |||
liquo-rice
approved these changes
Apr 25, 2024
|
|
||
| class Solution: | ||
| def addTwoNumbers(self, l1: Optional[ListNode], l2: Optional[ListNode]) -> Optional[ListNode]: | ||
| sentinel = ListNode() |
There was a problem hiding this comment.
dummy_headっていう名前もありですね。sentinelなのは確かにそうなんですが、どんなsentinelなのか名前だけからは分からないと思います。
| class Solution: | ||
| def addTwoNumbers(self, l1: Optional[ListNode], l2: Optional[ListNode]) -> Optional[ListNode]: | ||
| sentinel = ListNode() | ||
| tail_node = sentinel |
There was a problem hiding this comment.
tailだけもありです。ListNodeであることから、tail nodeであることは明らかですよね。
| tail_node = sentinel | ||
| carry = 0 | ||
| while l1 or l2 or carry: | ||
| add_value = carry |
There was a problem hiding this comment.
totalとかはどうでしょう。addを使うならadded_valueなら英語の響きがいいです。本当はsumが使いたいですよね…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.