`tinyglobby` can hang on invalid `fast-glob` backslash usage

[userquin]

Check vuejs/vitepress#4357

[SuperchupuDev]

i'm on windows and absolute patterns should work, can you provide a minimal repro? whatever it is if it's perf related #69 will probably solve it

[userquin]

clone VP (VitePress) repo then pnpm install && pnpm build

[SuperchupuDev]

it's using an absolute path with \s, which normally shouldn't be used in glob patterns in neither fast-glob or tinyglobby (https://github.com/mrmlnc/fast-glob#pattern-syntax). will investigate how fast-glob handles them when the pattern is absolute though

[userquin]

FYI: I added fast-glob in VP repo pnpm add -D fast-glob -w changing the rollup.config.ts import and usage and it works:

// foo.js => node ./foo.js
import { resolve, normalize } from 'node:path'
import { fileURLToPath } from 'node:url'
import { globSync } from 'tinyglobby'

const ROOT = fileURLToPath(import.meta.url)
const r = (p) => normalize(resolve(ROOT, '..', p))

console.log(r('src/node/worker_*.ts'))
console.log(
  globSync('src/node/worker_*.ts', {
    cwd: r('.'),
    onlyFiles: true,
    expandDirectories: false
  })
)
console.log('RUNNING')

[userquin]

https://github.com/mrmlnc/fast-glob?tab=readme-ov-file#how-to-write-patterns-on-windows

fast-glob handles that, but doesn't recommend

Using simple replacement works:

[userquin]

@SuperchupuDev https://github.com/mrmlnc/fast-glob/blob/da648078ae87bce81fcd42e64d5b2b1360c47b09/src/utils/path.ts#L57

[SuperchupuDev]

will try to make it as consistent to fast-glob as possible

[Torathion]

Any news on this? This is probably the biggest reason that prevents many tools from switch from fast-glob to tinyglobby.

[SuperchupuDev]

is it? thought it wasn't a priority since the issue author's linked repo no longer has the problem. can take a deeper look into it for the next release that i want to release ASAP

[Torathion]

From what I've gathered: The windows glob issues are very important. OP came from vitepress having this issue and remix and analog also referring to this issue. I wanted to make a PR in npm-check-updates and came across the same issue as a dozen tests started to fail after switching from fast-glob to tinyglobby.

[Sytten]

I would also say yes this is an issue, we use tsup to build plugins in our ecosystem and I got a report from a user that the build process was hanging on windows. It does look like it is related to tinyglobby.