Skip to content

Dockerfile + SetAttr Bug Fix #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wdahlenburg wants to merge 2 commits into
base: master
Choose a base branch
from
+14 −0
Open

Dockerfile + SetAttr Bug Fix #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
791d0ec
Guard attribute was missing on setattr calls
wdahlenburg Jun 23, 2022
bfa855b
Adding Dockerfile to compile old dependencies
wdahlenburg Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
FROM ubuntu:xenial-20161114 as build
RUN DEBIAN_FRONTEND=noninteractive apt-get update -y
RUN DEBIAN_FRONTEND=noninteractive apt-get install make gcc libtirpc-dev libncurses-dev libreadline-dev -y
COPY ./ /nfsshell
WORKDIR /nfsshell
RUN make

FROM ubuntu:xenial-20161114
COPY --from=build /nfsshell/nfsshell /bin/nfsshell
ENTRYPOINT ["/bin/nfsshell"]
4 changes: 4 additions & 0 deletions nfsshell.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1161,6 +1161,8 @@ do_chmod(int argc, char **argv)
aargs.new_attributes.atime = (set_atime) { .set_it=FALSE };
aargs.new_attributes.mtime = (set_mtime) { .set_it=FALSE };

aargs.guard.check = FALSE;

if ((ares = nfs3_setattr_3(&aargs, nfsclient)) == NULL) {
clnt_perror(nfsclient, "nfs3_setattr");
return;
Expand Down Expand Up @@ -1274,6 +1276,8 @@ do_chown(int argc, char **argv)
aargs.new_attributes.atime = (set_atime) { .set_it=FALSE };
aargs.new_attributes.mtime = (set_mtime) { .set_it=FALSE };

aargs.guard.check = FALSE;

if ((ares = nfs3_setattr_3(&aargs, nfsclient)) == NULL) {
clnt_perror(nfsclient, "nfs3_setattr");
return;
Expand Down