[FEAT][STK-186] - Add new frequency selector by ElRodrigote · Pull Request #212 · SwaprHQ/stackly-ui

ElRodrigote · 2024-11-22T00:03:34Z

Fixes: STK-186

Description

Creates the new Checkbox component
Creates the new TextInput component
Crates a FrequencyOpitonsCard component
Implements everything in the Stackbox

Visual Evidence

https://www.loom.com/share/6845f9de011f41c8b9ddb18986cd81f6?sid=207fdb56-359d-410b-a545-76d28a7e18b2

vercel · 2024-11-22T00:03:39Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
stackly-landing	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 2, 2024 11:15am

packages/app/components/stackbox/FrequencyOptionsCard.tsx

packages/app/components/stackbox/Stackbox.tsx

cloudflare-workers-and-pages · 2024-11-22T11:36:57Z

Deploying stackly-ui with Cloudflare Pages

Latest commit:	`f0b4258`
Status:	✅ Deploy successful!
Preview URL:	https://c0b27ef8.stackly-ui.pages.dev
Branch Preview URL:	https://feat-stk-186-add-new-frequen.stackly-ui.pages.dev

View logs

packages/app/components/stackbox/FrequencyOptionsCard.tsx

packages/app/ui/inputs/TextInput.tsx

packages/app/components/stackbox/FrequencyOptionsCard.tsx

… statement

berteotti

Looking good to me. Only this edge case is still happening. I input 33 weeks and then change to months frequency.

(max amount is 24 months)

packages/app/components/stackbox/FrequencyOptionsCard.tsx

packages/app/components/stackbox/Stackbox.tsx

packages/app/components/stackbox/FrequencyOptionsCard.tsx

… copy improvement

packages/app/ui/inputs/TextInput.tsx

Diogomartf · 2024-12-02T10:54:36Z

It's seems to have a bug. When I add a number, I can delete it. I should be able to.

For eg in the screenshot, I can't delete the 4.

ElRodrigote added 5 commits November 22, 2024 00:32

chore: update Headless dependency version

9be54df

feat: create the new Checkbox component

bd55e80

feat: create the new TextInput component

51760ca

feat: create the new FrequencyOptionsCard

11da961

feat: implement the new created frequency selector

9fc3453

ElRodrigote requested review from Diogomartf and berteotti November 22, 2024 00:03

Diogomartf reviewed Nov 22, 2024

View reviewed changes

packages/app/components/stackbox/FrequencyOptionsCard.tsx Outdated Show resolved Hide resolved

Diogomartf reviewed Nov 22, 2024

View reviewed changes

packages/app/components/stackbox/FrequencyOptionsCard.tsx Outdated Show resolved Hide resolved

Diogomartf reviewed Nov 22, 2024

View reviewed changes

packages/app/components/stackbox/Stackbox.tsx Outdated Show resolved Hide resolved

ElRodrigote added 2 commits November 22, 2024 12:14

prune: remove unwanted console log

832c79b

feat: address suggested frequencies comment in the PR

9ef013c

vercel bot deployed to Preview November 22, 2024 11:37 View deployment

fix: revert unwanted default day freq suggestion

1488a84

vercel bot deployed to Preview November 22, 2024 13:42 View deployment

Diogomartf reviewed Nov 23, 2024

View reviewed changes

packages/app/components/stackbox/FrequencyOptionsCard.tsx Outdated Show resolved Hide resolved

fix: remove unwanted timeframe magnitude from the frequency placeholder

50c295d

ElRodrigote requested a review from Diogomartf November 25, 2024 10:55

vercel bot deployed to Preview November 25, 2024 10:55 View deployment

berteotti reviewed Nov 26, 2024

View reviewed changes

packages/app/components/stackbox/FrequencyOptionsCard.tsx Outdated Show resolved Hide resolved

berteotti reviewed Nov 26, 2024

View reviewed changes

packages/app/components/stackbox/FrequencyOptionsCard.tsx Outdated Show resolved Hide resolved

berteotti reviewed Nov 26, 2024

View reviewed changes

packages/app/components/stackbox/FrequencyOptionsCard.tsx Outdated Show resolved Hide resolved

berteotti reviewed Nov 26, 2024

View reviewed changes

packages/app/ui/inputs/TextInput.tsx Outdated Show resolved Hide resolved

berteotti reviewed Nov 26, 2024

View reviewed changes

packages/app/ui/inputs/TextInput.tsx Outdated Show resolved Hide resolved

berteotti reviewed Nov 26, 2024

View reviewed changes

packages/app/ui/inputs/TextInput.tsx Outdated Show resolved Hide resolved

berteotti reviewed Nov 26, 2024

View reviewed changes

packages/app/components/stackbox/FrequencyOptionsCard.tsx Outdated Show resolved Hide resolved

ElRodrigote added 2 commits November 26, 2024 21:24

refactor: remove unneeded state variable

ac9ed06

refactor: update interface naming due to typo

08daa4b

ElRodrigote added 2 commits November 26, 2024 21:35

prune: remove unneeded props declaration

11c47c4

fix: update the function to compute the default end dates by frequency

df1fdcf

vercel bot deployed to Preview November 26, 2024 23:07 View deployment

berteotti reviewed Nov 27, 2024

View reviewed changes

packages/app/components/stackbox/FrequencyOptionsCard.tsx Outdated Show resolved Hide resolved

berteotti reviewed Nov 27, 2024

View reviewed changes

packages/app/components/stackbox/FrequencyOptionsCard.tsx Show resolved Hide resolved

berteotti reviewed Nov 27, 2024

View reviewed changes

packages/app/components/stackbox/FrequencyOptionsCard.tsx Show resolved Hide resolved

feat: use a console error instead throwing an error as default switch…

2c54ca6

… statement

vercel bot deployed to Preview November 27, 2024 11:40 View deployment

ElRodrigote added 2 commits November 27, 2024 12:56

feat: cleanup custom freq when using default freqs

ae1a3c5

feat: update frequency input to allow 1 as lowest input

c9e72df

ElRodrigote requested a review from berteotti November 27, 2024 12:46

vercel bot deployed to Preview November 27, 2024 12:47 View deployment

berteotti approved these changes Nov 27, 2024

View reviewed changes

Diogomartf reviewed Nov 27, 2024

View reviewed changes

packages/app/components/stackbox/FrequencyOptionsCard.tsx Outdated Show resolved Hide resolved

Diogomartf reviewed Nov 27, 2024

View reviewed changes

packages/app/components/stackbox/FrequencyOptionsCard.tsx Outdated Show resolved Hide resolved

Diogomartf reviewed Nov 27, 2024

View reviewed changes

packages/app/components/stackbox/FrequencyOptionsCard.tsx Outdated Show resolved Hide resolved

Diogomartf reviewed Nov 27, 2024

View reviewed changes

packages/app/components/stackbox/FrequencyOptionsCard.tsx Outdated Show resolved Hide resolved

Diogomartf reviewed Nov 27, 2024

View reviewed changes

packages/app/components/stackbox/Stackbox.tsx Outdated Show resolved Hide resolved

Diogomartf reviewed Nov 27, 2024

View reviewed changes

packages/app/components/stackbox/FrequencyOptionsCard.tsx Outdated Show resolved Hide resolved

ElRodrigote added 2 commits November 28, 2024 15:09

feat: clear custom freq input on frequency timeframe update

0a8850d

feat: update variable naming, conditional classname handling and page…

8caa567

… copy improvement

vercel bot deployed to Preview November 28, 2024 14:47 View deployment

Diogomartf reviewed Dec 2, 2024

View reviewed changes

packages/app/ui/inputs/TextInput.tsx Outdated Show resolved Hide resolved

ElRodrigote added 2 commits December 2, 2024 12:12

refactor: group TextInput styles by style context

e569283

feat: let the frequency TextInput allow empty values

f0b4258

vercel bot deployed to Preview December 2, 2024 11:15 View deployment

Diogomartf approved these changes Dec 2, 2024

View reviewed changes

ElRodrigote merged commit e99d943 into develop Dec 3, 2024

ElRodrigote deleted the feat/stk-186-add-new-frequency-selector branch December 3, 2024 12:16

Conversation

ElRodrigote commented Nov 22, 2024

Fixes: STK-186

Description

Visual Evidence

Uh oh!

vercel bot commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying stackly-ui with Cloudflare Pages

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

berteotti left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Diogomartf commented Dec 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel bot commented Nov 22, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Nov 22, 2024 •

edited

Loading

berteotti left a comment •

edited

Loading