Skip to content

Comments

Added option to omit excpetion edges in CFG#1

Open
ksons wants to merge 1 commit intoSwatinem:masterfrom
ksons:master
Open

Added option to omit excpetion edges in CFG#1
ksons wants to merge 1 commit intoSwatinem:masterfrom
ksons:master

Conversation

@ksons
Copy link

@ksons ksons commented Oct 25, 2013

Pass { omitExceptions: true } as second argument to esgraph ControlFlowGraph

It's usefull if excpetions should not be considered, either by the analysis or just for display purposes.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 5384f3a on ksons:master into a26fd60 on Swatinem:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling ec20bf9 on ksons:master into a26fd60 on Swatinem:master.

@Swatinem
Copy link
Owner

Thanks a lot for taking an interest in this project! :-)

It would be nice to have some tests for this feature. Lets make the testing framework recognize an additional comment with a JSON options in there.

Also, I wanted to avoid pulling in escodegen as dependency. dot should take the original source as label if you have range tracking enabled. Isn’t that working for you?

@ksons
Copy link
Author

ksons commented Oct 25, 2013

Hi,

actually I didn't want to pull that commit, it was done automatically (do I have to close the pull request to avoid that further commits end up in the pull request? I see the point having another dependency.

@Swatinem
Copy link
Owner

If you want you can open another one with added tests :-)

Includes test that fails before changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants