Parameters: fix flatten function for false parameters
#108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliSoftware
reviewed
Oct 7, 2018
Contributor
AliSoftware
left a comment
AliSoftware
left a comment
There was a problem hiding this comment.
Idk, shouldn't it be the responsibility of the template and Stencil to evaluate the parameter with value "false" to false instead?
Member
Author
|
This is unrelated to the templates. It has to do with our |
AliSoftware
reviewed
Oct 7, 2018
|
|
||
| let otherFlag = Parameters.flatten(dictionary: ["test": "a"]) | ||
| XCTAssertEqual(otherFlag, ["test=a"], "Non-boolean flag is flattened to a parameter with value") | ||
| } |
Contributor
There was a problem hiding this comment.
Should we add tests that Parameters.flatten(dictionary: ["test": "false"]) still passes the string "false" along (to check that we still make the distinction between false the Boolean and "false" the string?)
djbe
force-pushed
the
fix/parameters-flatten
branch
from
16edce5 to
6857076
Compare
AliSoftware
approved these changes
Oct 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SwiftGen/SwiftGen#434.