Skip to content

Swift 5 #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
djbe wants to merge 8 commits into from
Closed

Swift 5 #119

djbe wants to merge 8 commits into from

Conversation

@djbe
Copy link
Member

@djbe djbe commented Mar 3, 2019 •
edited
Loading

Few things:

  • lowerFirstWord crashes in swift 5 because scalars.index(after: start) crashes for an empty string. I've added a check for isEmpty before it, or we could invert the "after start" and "before end" checks. TBH, I think the isEmpty check is clearer in its intent.
  • We don't have a docker image with Swift 5 support yet.
  • Maybe we should drop swift versions older than 4.2.

@djbe djbe added this to the 2.8.0 milestone Mar 3, 2019
@djbe djbe force-pushed the feature/swift-5 branch 2 times, most recently from 4f39ad7 to 1497041 Compare March 3, 2019 17:05
@djbe djbe force-pushed the feature/swift-5 branch from 1497041 to 3409490 Compare March 3, 2019 17:07
AliSoftware
AliSoftware reviewed Mar 3, 2019
View reviewed changes
.ruby-version
@@ -1 +1 @@
2.3.7
2.4.5
Copy link
Contributor

@AliSoftware AliSoftware Mar 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's no need for newest additions in latest Ruby versions we should try to keep the Ruby version shipped with latest version of macOS (don't even know which it is and if 2.3.7 was already that) so that people not wanting to use rvm/rbenv won't have to worry. Except if you saw features in more recent Ruby versions that we needed?

Copy link
Member Author

@djbe djbe Mar 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually tried that in this PR (and the other PR in SwiftGen), but it starts complaining about an unknown version of ruby, so 🤷‍♂️

@djbe djbe force-pushed the feature/swift-5 branch from 3409490 to 06466e6 Compare March 3, 2019 17:40
@djbe
Copy link
Member Author

djbe commented Mar 3, 2019

I'm curious as to why linux swift 4.0 can't find Stencil... It has a Package.swift with the tools version set to 4.0. https://github.com/stencilproject/Stencil/blob/master/Package.swift

@AliSoftware AliSoftware changed the base branch from master to stable June 10, 2020 23:02
@djbe djbe mentioned this pull request Aug 29, 2020
Merged
AliSoftware
AliSoftware reviewed Aug 29, 2020
View reviewed changes
.circleci/config.yml
CIRCLE_TEST_REPORTS: /tmp/circleci-test-results
BUNDLE_PATH: vendor/bundle
docker:
- image: norionomura/jazzy:swift-4.2.0
Copy link
Contributor

@AliSoftware AliSoftware Aug 29, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a docker image with Swift 5 support yet.

Those Docker images with Swift 5 are now since available: https://github.com/norio-nomura/docker-jazzy

@djbe
Copy link
Member Author

djbe commented Oct 9, 2020

This PR is superseded by #127, which (amongst other things) upgrades to Swift 5.

@djbe djbe closed this Oct 9, 2020
@djbe djbe modified the milestones: 2.9.0, 2.8.0 Oct 9, 2020
@djbe djbe deleted the feature/swift-5 branch October 9, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AliSoftware AliSoftware AliSoftware left review comments

Assignees

No one assigned

Labels

type: enhancement

Projects

None yet

Milestone

2.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@djbe @AliSoftware