Skip to content
This repository was archived by the owner on Mar 26, 2023. It is now read-only.

Issue 163 #531

Merged
fassko merged 17 commits into from
Jul 2, 2020
Merged

Issue 163 #531

fassko merged 17 commits into from
Jul 2, 2020

Conversation

@fassko
Copy link
Member

@fassko fassko commented Jul 1, 2020 •
edited
Loading

Closes #528

@fassko fassko requested review from BasThomas and jessesquires July 1, 2020 19:04
@hal-codebot
Copy link

hal-codebot commented Jul 1, 2020 •
edited
Loading

1 Warning
⚠️ Looks like you’re publishing a new issue! 🎉
Don’t forget to:

  1. Review our style guide before merging
  2. After you merge, close the GitHub issue notes for this newsletter issue
  3. Open the next GitHub issue, add the correct labels, assign it to the next writer
  4. Run the new_draft.sh script and push the next draft
    5. <

Proselint found issues

_posts/2020-07-02-issue-163.md

Line Message Severity
7 More than 30 ppm of exclamations. Keep them under control. warning
153 'In light of' is cliché. warning
173 Months should be capitalized. 'June' is the preferred form. warning

Generated by 🚫 Danger

BasThomas
BasThomas approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@BasThomas BasThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ What an awesome issue, and I love the intro particularly!

@fassko fassko merged commit 3266a01 into master Jul 2, 2020
@fassko fassko deleted the ISSUE_163 branch July 2, 2020 16:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jessesquires jessesquires Awaiting requested review from jessesquires

1 more reviewer

@BasThomas BasThomas BasThomas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[163] Issue #163 - July 2, 2020

4 participants

@fassko @hal-codebot @BasThomas