Skip to content

fix(core): provider config parsing in workflow execution #2588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vigsterkr merged 2 commits into from
Jan 19, 2022
Merged

fix(core): provider config parsing in workflow execution #2588

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5587039
fix provider config parsing in workflow execution
Jan 19, 2022
a360a2e
Merge branch 'develop' into feature/2587-parse-provider-config
vigsterkr Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions renku/core/commands/workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,9 @@ def execute_workflow(

delete_indirect_files_list(client.path)

if config:
config = _safe_read_yaml(config)

started_at_time = local_now()

execute(dag=dag, basedir=client.path, provider=provider, config=config)
Expand Down Expand Up @@ -523,9 +526,6 @@ def _nested_dict():
f'{",".join(rv.missing_parameters)}'
)

if config:
config = _safe_read_yaml(config)

graph = ExecutionGraph([workflow], virtual_links=True)
execute_workflow(dag=graph.workflow_graph, command_name="execute", provider=provider, config=config)

Expand Down Expand Up @@ -734,8 +734,6 @@ def _iterate_workflow(

from renku.core.models.tabulate import tabulate

TAG_SEPARATOR = "@"

if mapping_path is None and len(mappings) == 0:
raise errors.UsageError("No mapping has been given for the iteration!")

Expand Down