fix(cli): allow renku run with many inputs#571
Merged
Conversation
ableuler
changed the title
ableuler
force-pushed
the
552-too-many-args
branch
from
8f1ae44 to
97efef6
Compare
ableuler
force-pushed
the
552-too-many-args
branch
from
97efef6 to
f0ea243
Compare
jsam
reviewed
Jul 3, 2019
Contributor
jsam
left a comment
jsam
left a comment
There was a problem hiding this comment.
Thanks for looking into this!
Note: This commit fixes only the case where a renku run command implicitly relies on many arguments which are NOT already expanded in the command line. Closes #552.
ableuler
force-pushed
the
552-too-many-args
branch
from
f0ea243 to
93a87f8
Compare
ableuler
force-pushed
the
552-too-many-args
branch
from
25ff524 to
d938423
Compare
jsam
approved these changes
Jul 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR in principle allows the execution of
renku runcommands with thousands of input arguments.Note: This commit resolves only the case where a renku run command implicitly relies on many arguments which are NOT already expanded on the command line.
Closes #552.