Fix zenodo export relative path#620
Merged
Merged
Conversation
rokroskar
reviewed
Aug 8, 2019
Member
rokroskar
left a comment
rokroskar
left a comment
There was a problem hiding this comment.
Looks good, just a minor question
ableuler
previously approved these changes
Aug 9, 2019
Contributor
ableuler
left a comment
ableuler
left a comment
There was a problem hiding this comment.
Looks good to me! 👍
And thanks for fixing the quotes that made the tests fail! 😎
…rnal github repository
Member
Author
|
Everything should work now without the key error. There was an issue with |
rokroskar
approved these changes
Aug 13, 2019
Member
rokroskar
left a comment
rokroskar
left a comment
There was a problem hiding this comment.
great, thanks for figuring this one out!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sets the
clientproperty of files in a dataset after the dataset has been loaded. This is needed to ensure thefull_pathproperty of files returns the correct path to a file irrespective of the current working directory.Also adds a new unit test to check for this case
Fixes #617
Type of change
Please select relevant options.
Checklist
Do not create pull request unless you checked all points.
(https://github.com/SwissDataScienceCenter/documentation/wiki/files/SDSC_Contributor_License_Agreement_v1.0.pdf).
./run-tests.shlocally.