fix: always add commit to dataset if possible#648
Merged
Conversation
jsam
suggested changes
Aug 27, 2019
Co-Authored-By: Sam <contact@justsam.io>
rokroskar
force-pushed
the
646-fix-missing-commit
branch
2 times, most recently
from
b8a8ce3 to
d85ff2a
Compare
jsam
reviewed
Aug 27, 2019
Contributor
jsam
left a comment
jsam
left a comment
There was a problem hiding this comment.
Looks great, but Travis is complaining. Can we fix the formating? 👍
rokroskar
force-pushed
the
646-fix-missing-commit
branch
from
d85ff2a to
2e1e82e
Compare
jsam
approved these changes
Aug 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always add a
committoDatasetif possible - in the case where a dataset is first being created withwith_dataset, it won't have been committed yet.This addresses #646 but needs the resolution of #639 for a full solution.
./run-tests.shlocally.