PHP 8 and psr-4 autoloading support#25
Open
faizanakram99 wants to merge 2 commits intoSybio:masterfrom
Open
Conversation
|
@Sybio have you had time to review this MR? It fixes #24 and updates the library to PSR which is highly important for this package and the developers who trust it. I've reviewed it and it looks good to me, if that is of any help. I'm mainly tagging you because I see this pull request has no reviewers assigned so maybe you had not seen it yet. |
|
There is only one thing missing. In PHP 8.0 images are no longed to: to make it load array of generated images. |
- fixes bug for PHP 8+ versions
Author
|
Thanks, changed |
pmtpro
approved these changes
Dec 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.