-
Notifications
You must be signed in to change notification settings - Fork 0
Now support all permission systems #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hmmm okay... Well I DEFINITELY like the idea of just using vault.. and eliminating the need for all these /lib jar's the maven's pom is all wacked because of this. Has this been tested for the major permission plugins that also dont require Vault? eg. Essentials Group Perms does not need Vault. (purely optional) |
|
Sycholic, I like the idea on relying on vault like we should be, but... I am not the maintainer. I believe making a pull request with https://github.com/vk2gpz/Lockette would be the proper place. (and sorry Im quite new to git let alone java so I dont know exactly the ins and outs when it comes to this stuff either) But I do like the idea, I am more worried now trying to fix other problems then permisisons (as I havent had any with PermissionsEX) and I'm to the point I feel like making a branch and just totally redoing the whole plugin... I wont close this as like I said Im not sure if it should be comming to me or not.— |
|
I seen that you did I dont mind either heck maybe Git did it automatically..? lol Im still new to how exactly git works on pull requests. If I know how to keep what you changed seperate from what Im working on currently I'll be glad to try it out.. (but again Im still newbie to git) but what ya did, I think is a good step in getting this plugin working more efficiently. getting the POM alone totally cleaned up is what Im working on now...I just havent pushed nothing up yet, since spigot and now CB are using maven for 1.8 |
|
I use GIT for my projects, but sometime, I have to problem and I have to erase and redo. I seen that you did I dont mind either heck maybe Git did it automatically..? lol Im still new to how exactly git works on pull requests. If I know how to keep what you changed seperate from what Im working on currently I'll be glad to try it out.. (but again Im still newbie to git) but what ya did, I think is a good step in getting this plugin working more efficiently. getting the POM alone totally cleaned up is what Im working on now...I just havent pushed nothing up yet, since spigot and now CB are using maven for 1.8— |
|
Here is the begin of my source code : https://github.com/Tabinol/Lock I use GIT for my projects, but sometime, I have to problem and I have to erase and redo. I seen that you did I dont mind either heck maybe Git did it automatically..? lol Im still new to how exactly git works on pull requests. If I know how to keep what you changed seperate from what Im working on currently I'll be glad to try it out.. (but again Im still newbie to git) but what ya did, I think is a good step in getting this plugin working more efficiently. getting the POM alone totally cleaned up is what Im working on now...I just havent pushed nothing up yet, since spigot and now CB are using maven for 1.8— |
Support Vault and Bukkit internal permission instead of include all permissions systems. Some permissions bugs are resolved.