Skip to content

Conversation

@Tabinol
Copy link

@Tabinol Tabinol commented Feb 18, 2015

Support Vault and Bukkit internal permission instead of include all permissions systems. Some permissions bugs are resolved.

@Sycholic
Copy link
Owner

Hmmm okay... Well I DEFINITELY like the idea of just using vault.. and eliminating the need for all these /lib jar's the maven's pom is all wacked because of this. Has this been tested for the major permission plugins that also dont require Vault? eg. Essentials Group Perms does not need Vault. (purely optional)

@Tabinol
Copy link
Author

Tabinol commented Feb 18, 2015

Sycholic,
Thank you and sorry, I sent the request to vk2gpz.
For now, I just tested with zPermission, a non-included plugin in actual Lockette source code.
The source code of this plugin is ugly. There is a lot of duplications and a lot of unnecessary codes. There is a lot of optimization to do.
I started from scratch a new sign protection plugin, but the problem is actually, I have a work and I have not enough time to continue. This is just a begin of code, and it is not usable. I can send you my source if you want.

 Le mercredi 18 février 2015 11h17, Sycholic <notifications@github.com> a écrit :

I like the idea on relying on vault like we should be, but... I am not the maintainer. I believe making a pull request with https://github.com/vk2gpz/Lockette would be the proper place. (and sorry Im quite new to git let alone java so I dont know exactly the ins and outs when it comes to this stuff either) But I do like the idea, I am more worried now trying to fix other problems then permisisons (as I havent had any with PermissionsEX) and I'm to the point I feel like making a branch and just totally redoing the whole plugin... I wont close this as like I said Im not sure if it should be comming to me or not.—
Reply to this email directly or view it on GitHub.

@Sycholic
Copy link
Owner

I seen that you did I dont mind either heck maybe Git did it automatically..? lol Im still new to how exactly git works on pull requests. If I know how to keep what you changed seperate from what Im working on currently I'll be glad to try it out.. (but again Im still newbie to git) but what ya did, I think is a good step in getting this plugin working more efficiently. getting the POM alone totally cleaned up is what Im working on now...I just havent pushed nothing up yet, since spigot and now CB are using maven for 1.8

@Tabinol
Copy link
Author

Tabinol commented Feb 18, 2015

I use GIT for my projects, but sometime, I have to problem and I have to erase and redo.
My source code is not Lockette, this is a completely new project. I will upload it to a separate repository and it will not affect Lockette repository. But before, I have to remove some dependencies. This is not a usable plugin but only a begin of code.

 Le mercredi 18 février 2015 15h12, Sycholic <notifications@github.com> a écrit :

I seen that you did I dont mind either heck maybe Git did it automatically..? lol Im still new to how exactly git works on pull requests. If I know how to keep what you changed seperate from what Im working on currently I'll be glad to try it out.. (but again Im still newbie to git) but what ya did, I think is a good step in getting this plugin working more efficiently. getting the POM alone totally cleaned up is what Im working on now...I just havent pushed nothing up yet, since spigot and now CB are using maven for 1.8—
Reply to this email directly or view it on GitHub.

@Tabinol
Copy link
Author

Tabinol commented Feb 18, 2015

Here is the begin of my source code : https://github.com/Tabinol/Lock
Sorry for comments in french, it is because it was first only for my server.

 Le mercredi 18 février 2015 15h55, Michel Blanchet <mblanchet@ymail.com> a écrit :

I use GIT for my projects, but sometime, I have to problem and I have to erase and redo.
My source code is not Lockette, this is a completely new project. I will upload it to a separate repository and it will not affect Lockette repository. But before, I have to remove some dependencies. This is not a usable plugin but only a begin of code.

 Le mercredi 18 février 2015 15h12, Sycholic <notifications@github.com> a écrit :

I seen that you did I dont mind either heck maybe Git did it automatically..? lol Im still new to how exactly git works on pull requests. If I know how to keep what you changed seperate from what Im working on currently I'll be glad to try it out.. (but again Im still newbie to git) but what ya did, I think is a good step in getting this plugin working more efficiently. getting the POM alone totally cleaned up is what Im working on now...I just havent pushed nothing up yet, since spigot and now CB are using maven for 1.8—
Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants