Add hsb functions to Ops8/Ops16. #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zestyping
reviewed
Sep 19, 2018
| * Returns a color given hue, saturation, brightness, and alpha. | ||
| */ | ||
| public static long hsba(double hue, double saturation, double brightness, double alpha) { | ||
| hue = hue * 360; |
Collaborator
There was a problem hiding this comment.
This line doesn't look like it should be here.
zestyping
reviewed
Sep 19, 2018
src/com/symmetrylabs/color/Ops8.java
Outdated
| public static int blue(int argb) { return argb & 0x000000ff; } | ||
|
|
||
| /** | ||
| * Returns hue value of a 16-bit color, from 0 to 1. |
Collaborator
There was a problem hiding this comment.
The function in Ops8 should operate on 8-bit colours, and the argument should be an int instead of a long.
zestyping
reviewed
Sep 19, 2018
src/com/symmetrylabs/color/Ops8.java
Outdated
| /** | ||
| * Returns the saturation of a 16-bit color, from 0 to 1. | ||
| */ | ||
| public static double saturation(long argb) { |
Collaborator
There was a problem hiding this comment.
saturation() and brightness() should take ints, not longs.
zestyping
reviewed
Sep 19, 2018
src/com/symmetrylabs/color/Ops8.java
Outdated
| /** | ||
| * Returns a color given hue, saturation, and brightness. | ||
| */ | ||
| public static long hsb(double hue, double saturation, double brightness) { |
Collaborator
There was a problem hiding this comment.
hsb() and hsba() should return ints, not longs.
Contributor
|
Ping covered everything I think; if you make the changes he suggested this all looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All values are between 0 and 1, method names are
hue,saturation,brightness,hsbandhsba.