Skip to content

Lock client fixes #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SUMUKHA-PK merged 24 commits into from
Oct 4, 2020
Merged

Lock client fixes #23

SUMUKHA-PK merged 24 commits into from
Oct 4, 2020

Conversation

@SUMUKHA-PK
Copy link
Contributor

@SUMUKHA-PK SUMUKHA-PK commented Oct 2, 2020 •
edited
Loading

This PR aligns the lock client to a common erroring methodology and makes it robust for implementations to come.

Also closed #21

SUMUKHA-PK and others added 22 commits July 20, 2020 22:17
@SUMUKHA-PK
implements an interface idea for #15
322c112
@SUMUKHA-PK
return owner details in CheckAcquire
5edcfd1
@SUMUKHA-PK
this commit implements in its entirity the method to watch locks only…
8930600 
… when caches are inexistent
@SUMUKHA-PK
this commit fixes some minor issues with formatting
c65adc7
@SUMUKHA-PK
fixed RemoveElement to reduce cache size, added cache vs non cache be…
0dae8af 
…nchmarks
@SUMUKHA-PK
this commit adds a wrapper for lock status check
ea80df4
@SUMUKHA-PK
this commit completes lock watching with a cache in the lockservice
3975b10
@SUMUKHA-PK
this commit adds more clarity on pouncing on a lock
38e3514
this commit adds some basic implementation of the Pounce function and…
52b008f 
… moves Acquire to acquire while allowing Acquire to call Pounce directly
this commit moves SimpleDescriptor to LockDescriptor
7d05753
this commit adds the new ObjectDescriptor type across the lockclient …
35be35b 
…and lockservice in view of #21
@SUMUKHA-PK
this commit has the POC of lock pouncing, tests will be implemented soon
ed46006
@SUMUKHA-PK
this commit resolves #17, implements lock-watching and lock-pouncing
5056971
@SUMUKHA-PK
this commit fixes a race condition on the err variables in the test file
45c6b67
@SUMUKHA-PK
this commit fixes a weird test fail
c4169b1
@SUMUKHA-PK
this commit fixes failing CI
a6b1173
@SUMUKHA-PK
this commit moves the timers outside the goroutines to have a determi…
7891b60 
…nistic test
@SUMUKHA-PK
this commit makes watching and pouncing dormant
3b9edcf
@SUMUKHA-PK
minor changes to pass tests
f88a078
@SUMUKHA-PK
removed unnecessary go mods
64e2cd3
@SUMUKHA-PK
fixes and aligns the lock client errors and makes it robust for futur…
ebaf297 
…e additions
@SUMUKHA-PK
this commit removes unnecessary files and fixes code based on suggest…
6f4b2e0 
…ions
suraj44
suraj44 requested changes Oct 2, 2020
View reviewed changes
@SUMUKHA-PK
Copy link
Contributor Author

SUMUKHA-PK commented Oct 3, 2020

Excellent excellent reviewing dude! We're upping the game like this. Im sure you learnt a lot and I did too. We're making our code neater and tighter with these reviews and learning with an excellent foundation for ourselves, lets keep it going!

PS: About the weird lower and upper case letter A's xD, it was because I was moving Acquire to acquire and I did a global find and replace. Will fix them so that they make sense :)

@SUMUKHA-PK SUMUKHA-PK merged commit 72a5dc6 into master Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suraj44 suraj44 suraj44 requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The new objectDescriptor object.

3 participants

@SUMUKHA-PK @suraj44