Implement Disposable Workspace in all Importers#100
Merged
Conversation
Contributor
Author
|
The pull request is finished by Andrea and me. FYI: @dcolleoni @dtrzesniak @amuolo |
dcolleoni
suggested changes
Nov 25, 2022
Contributor
dcolleoni
left a comment
dcolleoni
left a comment
There was a problem hiding this comment.
You are reverting many changes that were done in previous PR.
You have most probably resolved conflicts in the wrong way.
Thanks for fixing this.
added 2 commits
November 25, 2022 09:30
dcolleoni
approved these changes
Nov 25, 2022
dtrzesniak
pushed a commit
that referenced
this pull request
Nov 28, 2022
* Adding new workspaces where needed. * Changing last Workspaces to workspaces. * restore metadata * fix data node state validation + cleanups * fix text * fix text part 2 Co-authored-by: Andrea Muolo <amuolo@systemorph.com>
dtrzesniak
pushed a commit
that referenced
this pull request
Nov 29, 2022
* Adding new workspaces where needed. * Changing last Workspaces to workspaces. * restore metadata * fix data node state validation + cleanups * fix text * fix text part 2 Co-authored-by: Andrea Muolo <amuolo@systemorph.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#64