Skip to content

Materialize filter condition before the call to CommitToAsync() #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tkukuljan merged 2 commits into from
Jan 13, 2023
Merged

Materialize filter condition before the call to CommitToAsync() #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac28373
Bug fix.
tkukuljan Jan 13, 2023
199e53a
Going back to ExecuteAsync with importers in the PresentValue folder.
tkukuljan Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions PresentValueSeries/InitializeData.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"\n .WithType<ValuationApproach>() .WithType<RiskDriver>() .WithType<ProjectionConfiguration>() ",
"\n .WithType<ExchangeRate>()",
"\n .WithTarget(DataSource)",
"\n .ExecuteWithStoreActivityAsync(Session, DataSource, DataSetReader)"
"\n .ExecuteAsync()"
],
"metadata": {},
"execution_count": 0,
Expand All @@ -70,7 +70,7 @@
"await Import.FromFile(\"Dimensions.xlsx\")",
"\n .WithFormat(ImportFormats.AocConfiguration)",
"\n .WithTarget(DataSource)",
"\n .ExecuteWithStoreActivityAsync(Session, DataSource, DataSetReader)"
"\n .ExecuteAsync()"
],
"metadata": {},
"execution_count": 0,
Expand All @@ -82,7 +82,7 @@
"await Import.FromFile(\"DataNodes.xlsx\")",
"\n .WithFormat(\"DataNode\")",
"\n .WithTarget(DataSource)",
"\n .ExecuteWithStoreActivityAsync(Session, DataSource, DataSetReader)"
"\n .ExecuteAsync()"
],
"metadata": {},
"execution_count": 0,
Expand Down
4 changes: 2 additions & 2 deletions PresentValueSeries/PresentValue - Episode 2.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@
"await Import.FromFile(\"YieldCurve.xlsx\")",
"\n .WithType<YieldCurve>()",
"\n .WithTarget(DataSource)",
"\n .ExecuteWithStoreActivityAsync(Session, DataSource, DataSetReader)"
"\n .ExecuteAsync()"
],
"metadata": {},
"execution_count": 0,
Expand All @@ -183,7 +183,7 @@
"await Import.FromFile(\"Cashflows.xlsx\")",
"\n .WithFormat(\"Cashflow\")",
"\n .WithTarget(DataSource)",
"\n .ExecuteWithStoreActivityAsync(Session, DataSource, DataSetReader)"
"\n .ExecuteAsync()"
],
"metadata": {},
"execution_count": 0,
Expand Down
14 changes: 7 additions & 7 deletions PresentValueSeries/PresentValue - Episode 3.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@
"await Import.FromFile(\"DataNodes_CH.xlsx\")",
"\n .WithFormat(\"DataNode\")",
"\n .WithTarget(DataSource)",
"\n .ExecuteWithStoreActivityAsync(Session, DataSource, DataSetReader)"
"\n .ExecuteAsync()"
],
"metadata": {},
"execution_count": 0,
Expand All @@ -183,7 +183,7 @@
"await Import.FromFile(\"DataNodes_DE.xlsx\")",
"\n .WithFormat(\"DataNode\")",
"\n .WithTarget(DataSource)",
"\n .ExecuteWithStoreActivityAsync(Session, DataSource, DataSetReader)"
"\n .ExecuteAsync()"
],
"metadata": {},
"execution_count": 0,
Expand All @@ -195,7 +195,7 @@
"await Import.FromFile(\"YieldCurve.xlsx\")",
"\n .WithType<YieldCurve>()",
"\n .WithTarget(DataSource)",
"\n .ExecuteWithStoreActivityAsync(Session, DataSource, DataSetReader)"
"\n .ExecuteAsync()"
],
"metadata": {},
"execution_count": 0,
Expand All @@ -207,7 +207,7 @@
"await Import.FromFile(\"Cashflows.xlsx\")",
"\n .WithFormat(\"Cashflow\")",
"\n .WithTarget(DataSource)",
"\n .ExecuteWithStoreActivityAsync(Session, DataSource, DataSetReader)"
"\n .ExecuteAsync()"
],
"metadata": {},
"execution_count": 0,
Expand All @@ -219,7 +219,7 @@
"await Import.FromFile(\"CF_CH_2021_12.xlsx\")",
"\n .WithFormat(\"Cashflow\")",
"\n .WithTarget(DataSource)",
"\n .ExecuteWithStoreActivityAsync(Session, DataSource, DataSetReader)"
"\n .ExecuteAsync()"
],
"metadata": {},
"execution_count": 0,
Expand All @@ -231,7 +231,7 @@
"await Import.FromFile(\"CF_DE_2021_12.xlsx\")",
"\n .WithFormat(\"Cashflow\")",
"\n .WithTarget(DataSource)",
"\n .ExecuteWithStoreActivityAsync(Session, DataSource, DataSetReader)"
"\n .ExecuteAsync()"
],
"metadata": {},
"execution_count": 0,
Expand All @@ -243,7 +243,7 @@
"await Import.FromFile(\"CF_DE_2022_12.xlsx\")",
"\n .WithFormat(\"Cashflow\")",
"\n .WithTarget(DataSource)",
"\n .ExecuteWithStoreActivityAsync(Session, DataSource, DataSetReader)"
"\n .ExecuteAsync()"
],
"metadata": {},
"execution_count": 0,
Expand Down
11 changes: 6 additions & 5 deletions ifrs17/Import/Importers.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1365,17 +1365,18 @@
"\n if(Activity.HasErrors()) return Activity.Finish();",
"\n await DataNodeFactoryAsync(dataSet, ImportFormats.SimpleValue, args);",
"\n if(Activity.HasErrors()) return Activity.Finish();",
"\n ",
"\n",
"\n Guid partitionId = new Guid();",
"\n var workspace = Workspace.CreateNew();",
"\n var parsingLog = await ParseSimpleValueToWorkspaceAsync(dataSet, args, partitionId, workspace);",
"\n if(parsingLog.Errors.Any()) return Activity.Finish().Merge(parsingLog);",
"\n ",
"\n",
"\n workspace.Query<IfrsVariable>().Select(v => new {v.DataNode, v.AccidentYear}).Distinct();",
"\n ",
"\n await workspace.CommitToAsync<IfrsVariable,PartitionByReportingNodeAndPeriod>(DataSource, partitionId, snapshot : true,",
"\n filter : x => workspace.Query<IfrsVariable>().Select(v => v.DataNode).Distinct().Contains(x.DataNode));",
"\n",
"\n var targetDataNodes = workspace.Query<IfrsVariable>().Select(v => v.DataNode).Distinct().ToArray();",
"\n await workspace.CommitToAsync<IfrsVariable,PartitionByReportingNodeAndPeriod>(DataSource, partitionId, snapshot : true,",
"\n filter : x => targetDataNodes.Contains(x.DataNode));",
"\n ",
"\n return Activity.Finish().Merge(parsingLog);",
"\n});"
],
Expand Down