Skip to content

Clean up#175

Merged
dcolleoni merged 4 commits into
developfrom
cleanUp
Jan 16, 2023
Merged

Clean up#175
dcolleoni merged 4 commits into
developfrom
cleanUp

Conversation

@dcolleoni
Copy link
Copy Markdown
Contributor

  • ImportStorage : remove comment and extend logic to children AmountTypes
  • Importers > Compute : clean the workspace from the result of parsing before committing result to workspaceToCompute

@dcolleoni dcolleoni added the bug Something isn't working label Jan 14, 2023
@dcolleoni dcolleoni added this to the v1.0.x milestone Jan 14, 2023
@dcolleoni dcolleoni self-assigned this Jan 14, 2023
@dcolleoni dcolleoni linked an issue Jan 14, 2023 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@nnikolopoulos nnikolopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Comment thread ifrs17/Import/Importers.ipynb Outdated
@dcolleoni dcolleoni merged commit fc7ea03 into develop Jan 16, 2023
@dcolleoni dcolleoni deleted the cleanUp branch January 16, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Parsed and Computed IfrsVariables are both committed to DataSource

3 participants