Skip to content

fix with explicit names #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrey-katz-systemorph merged 2 commits into from
Aug 9, 2023
Merged

fix with explicit names #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
806baff
fix with explicit names
andrey-katz-systemorph Aug 8, 2023
3eac12a
Update Validations.ipynb
andrey-katz-systemorph Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ifrs17/Constants/Validations.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@
"\n (nameof(AocConfigurationOrderNotUnique), _) => $\"Two or more AoC Configurations have the same Order.\",",
"\n (nameof(AccidentYearTypeNotValid), 1) => $\"The parsed AccidentYear {s[0]} is invalid. Expected Accident Year input of type int.\",",
"\n (nameof(TableNotFound), 1) => $\"The import file does not contain table {s[0]}\",",
"\n (nameof(TableNotFound), 2) => $\"The import file contains neither table {s[0]} nor {s[1]}\",",
"\n",
"\n // Partition",
"\n (nameof(PartitionNotFound), _) => $\"Partition do not found.\",",
Expand Down Expand Up @@ -300,4 +301,4 @@
"outputs": []
}
]
}
}
3 changes: 2 additions & 1 deletion ifrs17/Import/Importers.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1290,7 +1290,8 @@
"\n Activity.Start();",
"\n var primaryArgs = GetArgsFromMain(dataSet) with {ImportFormat = ImportFormats.DataNodeParameter};",
"\n primaryArgs.ValidateArgsForPeriodAsync(options.TargetDataSource);",
"\n if (!dataSet.Tables.Contains(primaryArgs.ImportFormat)) ApplicationMessage.Log(Error.TableNotFound, primaryArgs.ImportFormat);",
"\n if (!dataSet.Tables.Contains(nameof(SingleDataNodeParameter)) && !dataSet.Tables.Contains(nameof(InterDataNodeParameter))) ",
"\n ApplicationMessage.Log(Error.TableNotFound, nameof(SingleDataNodeParameter), nameof(InterDataNodeParameter));",
"\n if(ApplicationMessage.HasErrors()) return Activity.Finish();",
"\n var workspace = Workspace.CreateNew();",
"\n workspace.Initialize(x => x.FromSource(options.TargetDataSource).DisableInitialization<RawVariable>().DisableInitialization<IfrsVariable>());",
Expand Down