Update release-packages.yml#19
Merged
Merged
Conversation
rbuergi
added a commit
that referenced
this pull request
May 10, 2026
… file lock The MESHWEAVER_DISPOSE_TRACE=1 trace took a global lock per call (`File.AppendAllText` under `lock (DisposeTraceLogLock)`), serialising hub teardown under load when many hubs disposed concurrently. Replaced with a single bounded `Channel<string>` (capacity 4096, FullMode = DropWrite) drained by one writer task started in the type initialiser. Producers `TryWrite` non-blocking — if the disk is slow / locked, lines drop on full instead of putting back-pressure on dispose. Single-reader semantics avoid contention on the file handle. Addresses PR #95 review item #19. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
rbuergi
added a commit
that referenced
this pull request
May 16, 2026
Mesh-hub HandleCreateNodeRequest / HandleUpdateNodeRequest writes to persistence directly (bypassing this hub's workspace) and fires DataChangeNotification.Updated with the saved entity. Without re-syncing the per-node hub's workspace, a fresh subscriber after delete + recreate gets the stale pre-write MeshNode — caught by WorkspaceCacheEvictionTest.AfterRecreate (test was failing for the better part of a session). Extends SubscribeToOwnDeletion's IDataChangeNotifier subscription: - Deleted on ownPath: cache.IsDeleted = true (existing behavior) - Created/Updated on ownPath: cache.IsDeleted = false; push the new entity through workspace.GetMeshNodeStream().Update() so the InstanceCollection refreshes; subsequent SubscribeRequests serve the live state. Tests (all green): WorkspaceCacheEvictionTest 2/2, DeleteNodeBehaviorTest 10/10, CreateOrUpdateNodeRequestTest 3/3. Closes task #19. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.