Update release-packages.yml#23
Merged
Merged
Conversation
rbuergi
added a commit
that referenced
this pull request
May 10, 2026
…fix DI lifetimes, redact PII, drop dynamic - ThreadExecution: collapse triple-stacked <summary> blocks on WatchForExecution and NotifyParentCompletion. Tooling kept the last one anyway; the dead scaffolding was just noise. - SocialExtensions: register LinkedInPublisher / XPublisher as TRUE singletons (factory-resolved with named HttpClient). The previous AddHttpClient<T>+AddSingleton<IPlatformPublisher> mix made the concrete type transient while the interface alias was singleton — direct vs via-interface resolution returned different instances. Also gate hosted-service registration on at least one platform being configured (the "all-or-nothing" comment was wrong; with zero platforms the four hosted services started anyway and faulted on first tick). - LinkedInPublisher: replace `(dynamic)media.shareMediaCategory` peek with two concrete payload shapes — typo turns into a compile error instead of a RuntimeBinderException. - LinkedIn / X publishers: cap error-body logs at 200 chars to bound PII exposure (the body can echo the user's post text on validation rejection). Full body still goes to PublishResult.Error for the caller. Addresses PR #95 review items #9, #20, #21, #22, #23. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
rbuergi
added a commit
that referenced
this pull request
May 10, 2026
… wire BuiltIn{Agent,Model} as partition providers
Three partition contracts (IPartitionStorageProvider + PartitionContexts +
StaticNodePartitionStorageProvider + StaticNodeStorageAdapter) lived in
MeshWeaver.Hosting.Persistence — too deep for MeshWeaver.AI to take as a
dep without pulling in the whole hosting tree. Moved to
MeshWeaver.Mesh.Services so node-type registration chains can wire a
partition shape directly. RoutingPersistenceServiceCore / PersistenceExtensions /
PartitionConfigurationExtensions / EmbeddedResourcePartitionStorageProvider /
OrleansConnectionExtensions all gain the new namespace via existing
'using MeshWeaver.Mesh.Services;' (PartitionConfigurationExtensions
needed the using added — others already had it).
AgentNodeType.AddAgentType + LanguageModelNodeType.AddLanguageModelType
now register the shared BuiltInAgentProvider / BuiltInLanguageModelProvider
instance as both:
- IStaticNodeProvider (legacy consumers: StaticNodeQueryProvider,
MeshDataSource fallback lookup, RoutingPersistenceServiceCore's
fan-in seed)
- IPartitionStorageProvider (canonical: routing core resolves
\"Agent\" / \"Model\" first-segment to the static partition's
StaticNodeStorageAdapter — no SeedIfAbsent fan-in copy required)
Closes task #23 (Migrate BuiltInAgentProvider + BuiltInLanguageModelProvider
to partition shape). The fan-in seed in RoutingPersistenceServiceCore.NewAdapterCore
stays as a safety net for any IStaticNodeProvider that doesn't (yet) have
a partition registration — letting #23 land without a flag-day cutover.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.