fix(api): case-insensitive contact matching on cruise import

[Systemsaholic]

Summary

• Fix duplicate contact creation during cruise booking import
• Root cause: exact case-sensitive eq() match on firstName/lastName
• Import normalizes names to title case but existing contacts may have different casing
• Switch to LOWER() comparison for case-insensitive matching

Test plan

• Verified TypeScript compilation passes
• Traced full import flow to confirm fix location
• No DB migration needed — query-only change

fixes #103

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Admin users can now toggle dashboard views between personal, agency, and combined perspectives to filter KPI and leaderboard data accordingly.
  • Contact matching during cruise booking imports is now case-insensitive for improved matching accuracy.

• Documentation

  • Added OTA consumer portal design specification documenting architecture, AI concierge features, advisor profiles, and referral attribution model.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2ea33cbf-8fa2-4d29-ac52-3f02a36d0cc1

📥 Commits

Reviewing files that changed from the base of the PR and between e6d7b01 and a17e681.

📒 Files selected for processing (7)

• apps/admin/src/app/dashboard/page.tsx
• apps/admin/src/hooks/use-dashboard.ts
• apps/api/src/cruise-booking/services/import-booking.service.ts
• apps/api/src/dashboard/dashboard.controller.ts
• apps/api/src/dashboard/dashboard.service.ts
• apps/api/src/dashboard/dto/dashboard-overview.dto.ts
• docs/superpowers/specs/2026-03-26-ota-consumer-portal-design.md

---

📝 Walkthrough

Walkthrough

Introduced a "view" selection feature to the admin dashboard enabling filtering between personal, agency, and combined views. Frontend manages view state with localStorage persistence; backend API supports the view query parameter to conditionally scope KPI queries and widget data. Also fixed contact matching to use case-insensitive comparison and documented the OTA consumer portal architecture.

Changes

Cohort / File(s)	Summary
Dashboard View Selection apps/admin/src/app/dashboard/page.tsx, apps/admin/src/hooks/use-dashboard.ts	Added DashboardView type and view state management with localStorage persistence. Updated dashboard to render KPI sections conditionally based on selected view (personal/agency/all), with admin-only view toggle. Hook now accepts and passes view parameter through query keys.
API View Parameter Support apps/api/src/dashboard/dto/dashboard-overview.dto.ts, apps/api/src/dashboard/dashboard.controller.ts, apps/api/src/dashboard/dashboard.service.ts	Extended dashboard overview endpoint with optional view query parameter. Service now makes KPI and widget queries conditional based on view type, returning empty KPI objects when skipped instead of undefined values. Widget data (getRecentTrips, getLeavingSoon) scoped by selected view.
Contact Import Enhancement apps/api/src/cruise-booking/services/import-booking.service.ts	Changed contact matching from exact first/last name comparison to case-insensitive matching using SQL LOWER() function.
OTA Consumer Portal Design docs/superpowers/specs/2026-03-26-ota-consumer-portal-design.md	Added comprehensive design specification for OTA consumer portal including Next.js frontend architecture, NestJS API integration, AI concierge chat, advisor profiles, referral attribution model, and Phase 2 roadmap.

Sequence Diagram(s)

sequenceDiagram
    actor Admin as Admin User
    participant UI as Dashboard Page
    participant Hook as useDashboardOverview
    participant QK as React Query
    participant API as Dashboard API
    participant Service as DashboardService
    participant DB as Database

    Admin->>UI: Select view (personal/agency/all)
    UI->>UI: setView(), persist to localStorage
    UI->>Hook: useDashboardOverview({view})
    Hook->>QK: queryKey includes {view}
    QK->>API: GET /dashboard/overview?view=X
    API->>Service: getOverview(auth, {view})
    
    alt view === 'personal' or 'all'
        Service->>DB: Query personal KPIs
        DB-->>Service: Personal KPI data
    end
    
    alt view === 'agency' or 'all'
        Service->>DB: Query agency KPIs & leaderboard
        DB-->>Service: Agency KPI data
    end
    
    Service->>Service: Compute trends if both prior+current
    Service-->>API: Dashboard overview (scoped by view)
    API-->>Hook: KPI response
    Hook-->>UI: Updated dashboard data
    UI->>UI: Render KPI sections conditionally
    UI-->>Admin: Display filtered dashboard

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat: dashboard revamp with KPIs, charts, and widgets #18: Extends the same dashboard overhaul by adding view-based filtering across frontend state management, hook parameters, and backend conditional query execution for KPI scoping.

Poem

🐰 A dashboard view, oh what a sight!
Personal, agency, or all in one flight,
With localStorage keeping your choice,
Admins now filter with confident voice,
And contacts match better, no matter the case! ✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feature/issue-103-contact-dedup

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
tailfire-client	Ready	Preview, Comment	Mar 26, 2026 4:08pm
tailfire-ota	Ready	Preview, Comment	Mar 26, 2026 4:08pm