feat: Super Search — global command palette (Cmd+K) by Systemsaholic · Pull Request #81 · Systemsaholic/tailfire

Systemsaholic · 2026-03-22T17:00:33Z

Summary

Global command palette (Cmd+K) in the admin navbar that searches across trips and contacts instantly
New unified GET /api/v1/search?q=<term>&limit=5 endpoint with proper access control via TripAccessService and ContactAccessService
Rich result rows: trip name + ref number + status badge + dates, contact name + email + phone
"View all" navigates to filtered table view (/trips?search=term, /contacts?search=term)
300ms debounce, min 2 chars, shouldFilter={false} for server-driven results

Files Changed (14 commits)

Backend: SearchModule, SearchService, SearchController, SearchQueryDto — parallel search with Promise.allSettled()
Frontend: SuperSearchDialog (Dialog + Command), useSearch hook, TopNav wiring
Shared types: SearchResponseDto, TripSearchResult, ContactSearchResult
List pages: Trips + contacts pages now support ?search= URL param with Suspense boundary

Test plan

Generated with Claude Code

Summary by CodeRabbit

Release Notes

New Features
- Added unified search dialog accessible via Cmd+K/Ctrl+K to find trips and contacts across the app.
- Search results display grouped by trips and contacts with relevant details and status information.
Improvements
- Search queries now reflected in page URLs for shareable filtered views.
- Trip and contact pages automatically sync with URL search parameters.

Fixes type mismatch where getTripStatusVariant() expects TripStatus but received plain string from the base SearchResultItem interface. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

"View all" from Super Search now navigates to /trips?search=term or /contacts?search=term. List pages read the param on mount, pre-fill the search input, and filter results. Trips page switches to table view when search param is present. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

useState only captures initial value once — useSearchParams resolves async in Next.js, so the initial render has empty params. Use useEffect to sync urlSearch into both searchInput and filters when it resolves. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Next.js 15 requires useSearchParams() to be inside a Suspense boundary for static page generation. Wrap trips and contacts pages with Suspense. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

vercel · 2026-03-22T17:00:39Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
tailfire-client	Ready	Preview, Comment	Mar 22, 2026 5:00pm
tailfire-ota	Ready	Preview, Comment	Mar 22, 2026 5:00pm

coderabbitai · 2026-03-22T17:00:51Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 779021a9-4c77-49c6-a55a-fe236a751d6e

📥 Commits

Reviewing files that changed from the base of the PR and between 225ce68 and d2416f0.

📒 Files selected for processing (12)

apps/admin/src/app/contacts/page.tsx
apps/admin/src/app/trips/page.tsx
apps/admin/src/components/layout/super-search-dialog.tsx
apps/admin/src/components/layout/top-nav.tsx
apps/admin/src/hooks/use-search.ts
apps/api/src/app.module.ts
apps/api/src/search/dto/search.dto.ts
apps/api/src/search/search.controller.ts
apps/api/src/search/search.module.ts
apps/api/src/search/search.service.ts
packages/shared-types/src/api/index.ts
packages/shared-types/src/api/search.types.ts

📝 Walkthrough

Walkthrough

The PR introduces a unified global search feature accessible via keyboard shortcut. It updates the contacts and trips pages to synchronize URL search parameters with UI state, adds a new Super Search Dialog component in the top navigation, creates a backend search endpoint that concurrently searches trips and contacts, and exports shared TypeScript types defining search result structures.

Changes

Cohort / File(s)	Summary
Admin UI - Page Wrappers `apps/admin/src/app/contacts/page.tsx`, `apps/admin/src/app/trips/page.tsx`	Wrapped pages with Suspense boundaries and added URL-driven search synchronization. Both pages now read the `search` query parameter and update internal state (`searchInput`, `filters.search`) when the URL changes. Trips page additionally switches to table view when search is active.
Admin UI - Search Dialog & Integration `apps/admin/src/components/layout/super-search-dialog.tsx`, `apps/admin/src/components/layout/top-nav.tsx`	Added new `SuperSearchDialog` component with Cmd+K/Ctrl+K keyboard shortcut support, integrated into `TopNav` with a `searchOpen` state to control dialog visibility and closure.
Admin Frontend - Search Hook `apps/admin/src/hooks/use-search.ts`	New `useSearch` hook that debounces queries by 300ms and performs GET requests to the `/search` endpoint via TanStack React Query, only executing when query length ≥ 2 characters.
API - Search Module `apps/api/src/search/search.controller.ts`, `apps/api/src/search/search.service.ts`, `apps/api/src/search/dto/search.dto.ts`, `apps/api/src/search/search.module.ts`, `apps/api/src/app.module.ts`	Introduced new `SearchModule` with a controller exposing `GET /search`, a service performing concurrent searches across trips and contacts with partial failure handling, and DTOs for query validation (requiring minimum 2-character query, optional limit 1–10, default 5).
Shared Types `packages/shared-types/src/api/search.types.ts`, `packages/shared-types/src/api/index.ts`	Added new search type definitions including `SearchResultType`, `TripSearchResult`, `ContactSearchResult`, `SearchResultGroup`, and `SearchResponseDto` with discriminated union types for typed search results.

Sequence Diagram(s)

sequenceDiagram
    actor User
    participant TopNav as TopNav Component
    participant Dialog as SuperSearchDialog
    participant Hook as useSearch Hook
    participant API as Search API
    participant Services as Trip/Contact Services
    
    User->>TopNav: Press Cmd+K or click search
    TopNav->>Dialog: Open dialog
    User->>Dialog: Type search query
    Dialog->>Hook: useSearch(query)
    Hook->>Hook: Debounce for 300ms
    Hook->>API: GET /search?q=query
    API->>Services: Concurrent search trips & contacts
    Services-->>API: Return results
    API-->>Hook: SearchResponseDto
    Hook-->>Dialog: Results with trips & contacts
    Dialog->>User: Display grouped results
    User->>Dialog: Click result item
    Dialog->>Dialog: Navigate via router.push()
    Dialog->>TopNav: Close dialog

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~55 minutes

Possibly related PRs

feat: dashboard revamp with KPIs, charts, and widgets #18: Modifies apps/admin/src/app/trips/page.tsx with similar viewMode initialization and URL search parameter synchronization patterns.

Poem

🔍 A rabbit hops through code so fine,
With Cmd+K, the searches align!
Trips and contacts dance in sync,
From frontend views to database's link—
One global search makes all dreams rhyme! ✨

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feature/super-search

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

Systemsaholic and others added 14 commits March 22, 2026 09:54

feat(shared-types): add search response type definitions

bdea076

feat(shared-types): add search.types.ts file

0ae97c5

feat(api): add search query DTO

c10a999

feat(api): add SearchService with trip and contact search

22c6fc0

feat(api): add SearchController with GET /search endpoint

6280971

feat(api): register SearchModule in app module

c70ec00

feat(admin): add useSearch hook with debounced query

91c72fa

feat(admin): add SuperSearchDialog command palette component

d406289

feat(admin): wire search button and Cmd+K to SuperSearchDialog

124edd8

fix(shared-types): type TripSearchResult.status as TripStatus

6337bf9

Fixes type mismatch where getTripStatusVariant() expects TripStatus but received plain string from the base SearchResultItem interface. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix(admin): add visually hidden DialogTitle for accessibility

f299f27

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix(admin): wrap useSearchParams in Suspense boundary

d2416f0

Next.js 15 requires useSearchParams() to be inside a Suspense boundary for static page generation. Wrap trips and contacts pages with Suspense. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Systemsaholic merged commit 67036c2 into main Mar 22, 2026
3 of 4 checks passed

Systemsaholic deleted the feature/super-search branch March 22, 2026 17:01

This was referenced Apr 2, 2026

feat(admin): Contacts CRM Portal — Phase 1: Backend + Enhanced Table #152

Merged

feat: Contact Merge + Duplicate Detection #157

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Super Search — global command palette (Cmd+K)#81

feat: Super Search — global command palette (Cmd+K)#81
Systemsaholic merged 14 commits intomainfrom
feature/super-search

Systemsaholic commented Mar 22, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented Mar 22, 2026

Uh oh!

coderabbitai Bot commented Mar 22, 2026 •

edited

Loading

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Systemsaholic commented Mar 22, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Files Changed (14 commits)

Test plan

Summary by CodeRabbit

Release Notes

Uh oh!

vercel Bot commented Mar 22, 2026

Uh oh!

coderabbitai Bot commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Systemsaholic commented Mar 22, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Mar 22, 2026 •

edited

Loading