Support for appending extra queries to Google searches #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the default bang is being used (Google), append any additional queries found other than the original "?q=%s" query. This allows for other queries to be passed to Google whenever default search is used, and extends functionality for us power users out there. This PR was originally made so that unduck wouldn't ignore the "udm=14" query I was passing it in my search engine settings: `https://unduck.link?q=%s&udm=14` Took the idea from [ThioJoe's video](https://www.youtube.com/watch?v=qGlNb2ZPZdc).
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
prov3ntus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the default bang is being used (Google), append any additional queries
?found other than the originalq=%squery.This allows for additional queries to be passed to Google whenever the default bang is used, and extends functionality for us power users out there.
This PR was originally made so that unduck wouldn't ignore the
udm=14query I was passing it in my search engine settings, but it can be used for any similar params you can think of that Google supports.These additional queries will still be ignored if using any bang other than Google (for obvious reasons).
This is what the URL looks like in my Search Engine settings for my browser:
https://unduck.link?q=%s&udm=14(also see pic below)Took the idea from this ThioJoe video.
I wanted to use
udm=14, but you can't use both this extra param and unduck simultaneously, without my suggested changes.EDIT: This is different from (and better than) the pull request #112 because it's not forcing any params; the end user still has full control over what params are passed, and what values they have.
Would love to see this be merged, I think this would be cool for a lot of people. 💪💪