Skip to content

Conversation

@nathanfranklin
Copy link
Collaborator

@nathanfranklin nathanfranklin commented Dec 15, 2025

Overview:

This PR fixes various things in "File Accessibility Validation Check" modal

  • Fixes error in “There are N asset(s)” text
  • Adds missing "?" to end of questions
  • Uses Private label (instead of Unknown label) for those features where we don't know there system/path and can' determine if they are public
  • Fixes link for layers
  • Increases vertical space taken by table

PR Status:

  • Ready.

Related Jira tickets:

@nathanfranklin nathanfranklin changed the title Fix modal text, size and labels task/WG-613: Fix "File Accessibility Validation Check" modal text, size and labels Dec 15, 2025
Copy link
Contributor

@rstijerina rstijerina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nathanfranklin and others added 6 commits December 15, 2025 12:55
Fix to the linting error in MapControlbar.tsk on 92/93.

Co-authored-by: Nathan Franklin <nathan.franklin@gmail.com>
…f github.com:TACC-Cloud/hazmapper into task/WG-613-fix-issues-with-file-accessibility-modal
Copy link
Contributor

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nathanfranklin nathanfranklin merged commit 0e5f84e into main Dec 15, 2025
5 checks passed
@nathanfranklin nathanfranklin deleted the task/WG-613-fix-issues-with-file-accessibility-modal branch December 15, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants