Skip to content

Conversation

@rstijerina
Copy link
Member

Overview

Adds the hostEval param in a datafiles storage system object in PORTAL_DATAFILES_DEFAULT_STORAGE_SYSTEM, which can be used to set the base homeDir in lieu of parsing homeDir.

Related

Changes

  • Adds the evaluate_datafiles_storage_system and evaluate_datafiles_storage_systems utils
  • Updates tapipy to latest

Testing

  1. Go to datafiles and ensure your frontera scratch evaluates correctly
  2. Submit a job on frontera, deleting the auto populated archive path, and confirm behavior as usual

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.75%. Comparing base (2417dba) to head (5b65e3a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
server/portal/apps/datafiles/utils.py 83.33% 1 Missing and 1 partial ⚠️
server/portal/apps/workspace/api/views.py 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1185      +/-   ##
==========================================
+ Coverage   70.74%   70.75%   +0.01%     
==========================================
  Files         540      540              
  Lines       33879    33894      +15     
  Branches     2801     2803       +2     
==========================================
+ Hits        23969    23983      +14     
  Misses       9708     9708              
- Partials      202      203       +1     
Flag Coverage Δ
javascript 72.92% <ø> (ø)
unittests 61.53% <87.50%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
server/portal/apps/datafiles/views.py 75.12% <100.00%> (-0.13%) ⬇️
server/portal/apps/jupyter_mounts/api/views.py 84.90% <100.00%> (+0.90%) ⬆️
server/portal/settings/settings.py 0.00% <ø> (ø)
server/portal/settings/settings_default.py 0.00% <ø> (ø)
server/portal/apps/datafiles/utils.py 88.23% <83.33%> (-11.77%) ⬇️
server/portal/apps/workspace/api/views.py 56.58% <50.00%> (+0.51%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@fnets fnets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I wasn't able to test any apps out locally but everything else worked great. Thanks for updating Tapispy!

Copy link
Contributor

@jmartinez-tacc jmartinez-tacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rstijerina rstijerina merged commit 10d4caa into main Dec 4, 2025
6 checks passed
@rstijerina rstijerina deleted the task/WI-353--use-hosteval-to-mount-scratch branch December 4, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants