Skip to content

Conversation

@fnets
Copy link
Contributor

@fnets fnets commented Dec 9, 2025

Overview

Updating yup regex validator on keywords to include trailing spaces and hypens.

Related

Testing

  1. Open a shared workspace and edit the keywords to include a leading and trailing space and insert a hyphen into any word. Make sure keywords still need to be comma-separated.
  2. Create a shared workspace and initiate the keywords to include a leading and trailing space and insert a hyphen into any word. Make sure keywords still need to be comma-separated.
  3. Try to break this field.

@fnets fnets changed the title hotfix: Updating regex validator on keywords to include trailing spaces and h… hotfix: Updating regex validator on keywords Dec 9, 2025
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.67%. Comparing base (7a9a35f) to head (35bdc15).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...Files/DataFilesModals/DataFilesAddProjectModal.jsx 50.00% 1 Missing ⚠️
...lesModals/DataFilesProjectEditDescriptionModal.jsx 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1193   +/-   ##
=======================================
  Coverage   70.67%   70.67%           
=======================================
  Files         543      543           
  Lines       34129    34129           
  Branches     2843     2843           
=======================================
  Hits        24122    24122           
  Misses       9804     9804           
  Partials      203      203           
Flag Coverage Δ
javascript 73.00% <50.00%> (ø)
unittests 60.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...Files/DataFilesModals/DataFilesAddProjectModal.jsx 81.03% <50.00%> (ø)
...lesModals/DataFilesProjectEditDescriptionModal.jsx 88.88% <50.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@rstijerina rstijerina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rstijerina rstijerina merged commit a1277ba into main Dec 11, 2025
4 checks passed
@rstijerina rstijerina deleted the hotfix/keywords-validator branch December 11, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants