task/WI-351: Allow an explicit Git tag to be passed to Make commands via Jenkins #1194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently the Makefile uses
git describeon the current branch/tag to determine how to tag Docker images for release. When multiple tags point to the same commit, this can cause the wrong tag to be used.This PR allows the lookup to be bypassed if the GIT_TAG variable is set upstream by Jenkins. On the Jenkins side, the deploy script has been updated with a $branch_deploy checkbox arg, defaulting to
false. Unless it is checked, we run the following code:This lets deployers opt in to using a branch name to deploy, while the default behavior is to pass the release tag without modification.
Related