Skip to content

Conversation

@wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Sep 21, 2023

Overview

Migrate CSS to https://github.com/TACC/Core-Styles/.

To Do

  • migrate news, at least
  • remove news, at least

Related

Changes

  • changed c-news to match recent changes to Core-CMS's Django CMS Blog CSS
    this is temporary record keeping; migration will remove these files from tup-cms

Testing

UI

@wesleyboar wesleyboar changed the title chore: updates from core-cms blog styles to c-news feat: tup-463 migrate css to core-styles Sep 21, 2023
@wesleyboar wesleyboar changed the title feat: tup-463 migrate css to core-styles feat: tup-463 migrate css to core-styles - news Oct 10, 2023
@wesleyboar wesleyboar changed the title feat: tup-463 migrate css to core-styles - news chore: tup-463 migrate css to core-styles - news Oct 13, 2023
@wesleyboar wesleyboar added the migrate css to core Migrate CSS to Core-CMS or Core-Styles label Oct 13, 2023
@wesleyboar wesleyboar changed the title chore: tup-463 migrate css to core-styles - news chore: tup-621 migrate css to core-styles - news Oct 13, 2023
@wesleyboar wesleyboar mentioned this pull request Oct 13, 2023
14 tasks
@wesleyboar wesleyboar changed the base branch from main to feat/tup-463 October 13, 2023 16:33
R-Tomas-Gonzalez and others added 19 commits October 16, 2023 10:23
* feat: tup-619 c-content block migration

* removed content-block import
* migrated c-update to core-styles

* removed c-update import
* feat: tup-624: added generics/attributes to demo

* migrated rest of attributes.css to core-styles

* removed unnecessary comments in css file for c-button
* getting rid of django.cms.blog.app.item.css

* removing the import for django.cms.blog.app.item.css
Co-authored-by: Wesley Bomar <wbomar@tacc.utexas.edu>
Co-authored-by: Wesley Bomar <wbomar@tacc.utexas.edu>
WARNING: v2.17.3 causes login form field bug.
No need for u-highlight per jira ticket

Co-authored-by: Wesley B <62723358+wesleyboar@users.noreply.github.com>
Co-authored-by: Wesley Bomar <wbomar@tacc.utexas.edu>
* I believe this has already been merged into core-styles... Padding and Margin seem to be available on prod

* remove import of core-styles o-heading-steps.css
@wesleyboar wesleyboar marked this pull request as ready for review November 16, 2023 20:54
@wesleyboar wesleyboar marked this pull request as draft November 16, 2023 20:54
wesleyboar and others added 11 commits November 16, 2023 14:55
* bug/tup-650: Remove padding-block from cms

* adjusted comments to relative code blocks
* fix: tup-654 use c-form--login from core-styles

* chore: tup-654 remove redundant `c-form` classname
Some Core-Styles were loaded via CDN, cuz CMS did not have latest yet.

Now CMS has much more recent Core-Styles, so use them. Do not duplicate.
* chore: tup-463 remove temp. core-styles imports

Some Core-Styles were loaded via CDN, cuz CMS did not have latest yet.

Now CMS has much more recent Core-Styles, so use them. Do not duplicate.

* chore: tup-463 delete css modules mimicking core

Some Core-Styles CSS was added after TUP login form was developed.

Now that it is available, TUP lofin form can use it. Less module CSS!

* style: npx nx format:write
Some Core-Styles CSS was added after TUP login page was developed.

Now that it is available, TUP login page can use it. Less module CSS!
Base automatically changed from feat/tup-463 to main November 30, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

migrate css to core Migrate CSS to Core-CMS or Core-Styles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants