Fix static linking: all variables need to be defined#99
Merged
lluisp merged 2 commits intoTALP-UPC:masterfrom Jul 1, 2020
Merged
Fix static linking: all variables need to be defined#99lluisp merged 2 commits intoTALP-UPC:masterfrom
lluisp merged 2 commits intoTALP-UPC:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #96
In order to link statically all the
externvariables need to be defined (we cannot fool the compiler). These variables were originally defined in themain()function infoma.c, but this function was removed. Maybe to usefomaas a library some of these files are not needed, this is something we could investigate.I hope these changes don't break anything