Feat/tag input#114
Merged
Merged
Conversation
Contributor
|
|
Contributor
|
Contributor
|
Contributor
对比react
|
Contributor
|
Contributor
|
Contributor
|
Contributor
|
Contributor
|
duenyang
reviewed
Aug 29, 2024
Comment on lines
+2
to
+3
| import { InputProps } from '../input'; | ||
| import { InputValue } from '../input'; |
Comment on lines
+3
to
+6
| import inputStyles from '../../_common/style/web/components/input/_index.less'; | ||
| import tagStyles from '../../_common/style/web/components/tag/_index.less'; | ||
| import styles from '../../_common/style/web/components/tag-input/_index.less'; | ||
| import theme from '../../_common/style/web/theme/_index.less'; |
| onRemove: Function, | ||
| }; | ||
|
|
||
| install() { |
Comment on lines
+115
to
+121
| this.tagInputRef = createRef(); | ||
| this.isCompositionRef = createRef(); | ||
| this.tagValue = this.props?.defaultValue || []; | ||
| this.draggingIndex = -1; | ||
| this.dragStartData = null; | ||
| this.isDropped = null; | ||
| this.startInfo = { nodeX: 0, nodeWidth: 0, mouseX: 0 }; |
Contributor
There was a problem hiding this comment.
除了 this.tagValue ，其它的变量都可以在定义时设置默认值，无需在这里赋值
duenyang
reviewed
Aug 29, 2024
| onMouseleave, | ||
| } = props; | ||
|
|
||
| const useDragSorter = <T,>(props: DragSortProps<T>): DragSortInnerProps => { |
Contributor
There was a problem hiding this comment.
render内太多函数逻辑，需要提取出来，只保留变量相关
This was referenced Oct 17, 2024
Closed
This was referenced Dec 16, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
#26
💡 需求背景和解决方案
📝 更新日志
feat(tag-input): 添加 tag-input 组件
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单