Skip to content

feat(upload): add upload component#126

Merged
duenyang merged 23 commits into
TDesignOteam:mainfrom
wadwings:main
Aug 29, 2024
Merged

feat(upload): add upload component#126
duenyang merged 23 commits into
TDesignOteam:mainfrom
wadwings:main

Conversation

@wadwings
Copy link
Copy Markdown
Contributor

@wadwings wadwings commented Aug 2, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • [✅] 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#16

💡 需求背景和解决方案

feat(upload): add upload component

📝 更新日志

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • [✅] 文档已补充或无须补充
  • [✅] 代码演示已提供或无须提供
  • [✅] TypeScript 定义已补充或无须补充
  • [✅] Changelog 已提供或无须提供

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 2, 2024

失败

@duenyang
Copy link
Copy Markdown
Contributor

duenyang commented Aug 2, 2024

image image image image

整体缺少多文件上传、拖拽上传、自定义风格上传 example

@wadwings
Copy link
Copy Markdown
Contributor Author

wadwings commented Aug 2, 2024

image image image image
整体缺少多文件上传、拖拽上传、自定义风格上传 example

一期不要求实现[多文件上传、拖拽上传、自定义风格上传]等内容

样式问题可以改造,但根本原因在于引入一个omi组件时会形成ShadowDOM局部作用域,导致原来部分CSS选择器(如这里的loading组件的CSS选择器其实是'.t-upload__single-progress .t-loading)在omi框架下不受支持

@duenyang
Copy link
Copy Markdown
Contributor

duenyang commented Aug 2, 2024

image image image image
整体缺少多文件上传、拖拽上传、自定义风格上传 example

一期不要求实现[多文件上传、拖拽上传、自定义风格上传]等内容

样式问题可以改造,但根本原因在于引入一个omi组件时会形成ShadowDOM局部作用域,导致原来部分CSS选择器(如这里的loading组件的CSS选择器其实是'.t-upload__single-progress .t-loading)在omi框架下不受支持

可以使用_util/lightDom下的转换函数,把loading的shadowDom去掉

Comment thread src/upload/upload.tsx Outdated
Comment thread src/upload/upload.tsx Outdated
Comment thread src/upload/upload.tsx
Comment thread src/upload/upload.tsx Outdated
Comment thread src/upload/upload.tsx Outdated
Comment thread src/upload/ImageCard.tsx Outdated
Comment thread src/upload/upload.tsx Outdated
@duenyang duenyang merged commit 163c7ac into TDesignOteam:main Aug 29, 2024
This was referenced Oct 17, 2024
This was referenced Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants