feat: textarea问题修复#49
Merged
Merged
Conversation
added 3 commits
June 19, 2024 17:16
carolin913
reviewed
Jun 21, 2024
| {{ base }} | ||
|
|
||
| ### 自定义事件 | ||
|
|
duenyang
reviewed
Jun 21, 2024
Comment on lines
+77
to
+94
| if (autosize === true) { | ||
| node.addEventListener('input', () => { | ||
| const heightObj = calcTextareaHeight(node); | ||
| const clacMinHeight = heightObj.minHeight; | ||
| const clacHeight = heightObj.height; | ||
| node.style.minHeight = clacMinHeight; | ||
| node.style.height = clacHeight; | ||
| }); | ||
| } else if (typeof autosize === 'object') { | ||
| node.addEventListener('input', () => { | ||
| const heightObj = calcTextareaHeight(node, autosize?.minRows, autosize?.maxRows); | ||
| const clacMinHeight = heightObj.minHeight; | ||
| const clacHeight = heightObj.height; | ||
| node.style.minHeight = clacMinHeight; | ||
| node.style.height = clacHeight; | ||
| }); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
代码重复度过高可以合并，另外不建议使用addEventListener可以在标签处使用 onInput={this.onInput},然后定义对应方法
@bind
onInput(){...}| }); | ||
| } | ||
|
|
||
| inputValueChangeHandle = (e: Event) => { |
Contributor
There was a problem hiding this comment.
使用 omi的 @bind，调用处不需要使用箭头函数
This was referenced Oct 17, 2024
Closed
This was referenced Dec 16, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
fix(组件名称): 处理问题或特性描述 ...
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单