feat(input): add input component and its examples#78
Merged
Conversation
fix name error
fix name error
duenyang
reviewed
Jul 10, 2024
duenyang
reviewed
Jul 12, 2024
| }, | ||
| className, | ||
| )} | ||
| ref={this.wrapperRef} |
Contributor
There was a problem hiding this comment.
fetch完最新的main代码后，所有的ref需要放到属性的最后面，避免omi最新版获取不到ref的问题
<div ...其它的属性在前 ref=XXX>
| disabled, | ||
| status, | ||
| size, | ||
| class: className, |
carolin913
approved these changes
Jul 15, 2024
| } | ||
|
|
||
| function handleClear(e: MouseEvent) { | ||
| console.log('clear'); |
| </div> | ||
| ); | ||
|
|
||
| function handleChange(e) { |
Contributor
There was a problem hiding this comment.
这些事件的处理函数不要都放到render里面，单独在外面定义private方法
This was referenced Oct 17, 2024
Closed
This was referenced Dec 16, 2024
Closed
RylanBot
reviewed
Mar 18, 2026
| return result ? ( | ||
| <span class={classname(`${classPrefix}-input__${type} ${iconClassName}`)}>{result}</span> | ||
| ) : ( | ||
| <span></span> |
Collaborator
There was a problem hiding this comment.
这个空 span 有什么含义吗 🤔
今天在看 DOM 结构的时候发现了这个
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
#25
💡 需求背景和解决方案
📝 更新日志
添加input组件和input组件相关示例（addon组件未实现）
fix(组件名称): 处理问题或特性描述 ...
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单