Conversation
- MissionCard 관련 코드 삭제 - descriptionTextStyle -> nullable로 변경
WalkthroughCherrishSectionChipType 열거형을 제거하고 SelectionSection 컴포넌트를 리팩토링합니다. 함수명을 변경하고, 패키지 위치를 이동하며, MissionCard 분기를 제거하고 CherrishSelectionChip만 사용하도록 통합합니다. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🧰 Additional context used📓 Path-based instructions (1)**/*.kt⚙️ CodeRabbit configuration file
Files:
🧠 Learnings (1)📚 Learning: 2026-01-12T19:49:27.085ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
app/src/main/java/com/cherrish/android/presentation/calendar/procedure/component/SelectionSection.kt (1)
55-81: 72번 라인의 불필요한 빈 줄을 제거하세요.
itemsIndexed람다의 매개변수 다음에 있는 빈 줄(72번)은 제거하면 코드 가독성이 개선됩니다.또한
LazyVerticalGrid에 명시적인 높이 제약이 없어서, 이 컴포넌트가 향후 스크롤 가능한 부모 컨테이너(예:LazyColumn,verticalScroll())에 통합될 때 중첩 스크롤 문제가 발생할 수 있습니다. 사용 사례에 따라wrapContentHeight()또는 부모에서 높이를 제한하는 방식으로 처리하는 것을 권장합니다.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
app/src/main/java/com/cherrish/android/core/designsystem/component/type/CherrishSectionChipType.ktapp/src/main/java/com/cherrish/android/presentation/calendar/procedure/component/SelectionSection.kt
💤 Files with no reviewable changes (1)
- app/src/main/java/com/cherrish/android/core/designsystem/component/type/CherrishSectionChipType.kt
🧰 Additional context used
📓 Path-based instructions (1)
**/*.kt
⚙️ CodeRabbit configuration file
**/*.kt: - Jetpack Compose 구조, 상태 관리, recomposition 최적화에 집중
- ViewModel, UiState, 단방향 데이터 흐름 패턴 검토
- 불필요한 recomposition 가능성, remember/derivedStateOf 적절한 사용 확인
- 네이밍 컨벤션, 가독성, Google 권장 Android 아키텍처 준수 여부
Files:
app/src/main/java/com/cherrish/android/presentation/calendar/procedure/component/SelectionSection.kt
🧠 Learnings (1)
📚 Learning: 2026-01-12T19:49:27.085Z
Learnt from: nhyeonii
Repo: TEAM-Cherrish/Cherrish-Android PR: 41
File: app/src/main/java/com/cherrish/android/presentation/challenge/ChallengeScreen.kt:30-39
Timestamp: 2026-01-12T19:49:27.085Z
Learning: When a Jetpack Compose screen composable receives a Scaffold paddingValues: PaddingValues parameter (commonly from Scaffold), apply it to the root container's modifier first (e.g., .padding(paddingValues)) before applying any additional padding. This ensures content respects system bars (status/navigation) and avoids layout overlap. This pattern should be followed across presentation screens under app/src/main/java/com/cherrish/android/presentation/ to maintain consistent insets handling.
Applied to files:
app/src/main/java/com/cherrish/android/presentation/calendar/procedure/component/SelectionSection.kt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: PR Build Check
- GitHub Check: PR Lint Check
🔇 Additional comments (3)
app/src/main/java/com/cherrish/android/presentation/calendar/procedure/component/SelectionSection.kt (3)
26-53: LGTM!PR 목표에 맞게
CherrishSelectionSection에서SelectionSection으로 이름이 변경되었고,descriptionTextStyle이 nullable로 변경되었습니다. 파라미터 순서(필수 파라미터 → modifier → 선택적 파라미터)가 Compose 컨벤션을 잘 따르고 있으며, 상태 호이스팅 패턴도 적절히 적용되어 있습니다.
83-109: LGTM!
descriptionTextStyle가 nullable로 변경되었고, null일 경우 기본 스타일(CherrishTheme.typography.body1R14)을 사용하는 방식이 깔끔합니다.isNullOrBlank()체크를 통한 description 처리도 적절합니다.
111-141: LGTM!Preview 함수들이
SelectionSection의 두 가지 사용 케이스(description 유무)를 잘 테스트하고 있습니다.mutableIntStateOf사용과persistentListOf를 통한 불변 리스트 활용이 적절합니다.
3 participants
Related issue 🛠
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
N/A
To Reviewers 📢
CherrishSelectionSection .. 미션카드 컴포넌트 수정되면서 SelectionSection으로 강등됏습니다ㅜㅜ 파일 위치랑 파일 이름이랑 다 바꿧어용~~
Summary by CodeRabbit
릴리스 노트
✏️ Tip: You can customize this high-level summary in your review settings.