Skip to content

Grading/Feedback PR [DO NOT MERGE]#33

Open
martypdx wants to merge 2 commits intoTEAMBENTO:masterfrom
martypdx:master
Open

Grading/Feedback PR [DO NOT MERGE]#33
martypdx wants to merge 2 commits intoTEAMBENTO:masterfrom
martypdx:master

Conversation

@martypdx
Copy link
Copy Markdown

@martypdx martypdx commented Jul 3, 2018

Good, simple routes. Some of the db work could be cleaner and avoid unnecessary work.

  • Good testing and testing coverage (both unit and e2e)
  • Routes look good with async/await "respond"!
  • Make sure not to leak User password hash!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant