feat: notification refinements, passport checklist fixes and goals polish#94
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
AI PR Summary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up QA fixes covering notification spam, passport checklist accuracy, goals page improvements, and transaction UI polish.
Notifications
Fixed large expense notification spam — notifications now use stable unique IDs based on transaction ID and type, preventing duplicates on page reload
Migrated notification store to Zustand persist middleware — cleaner and more reliable than manual localStorage
Added income recorded and expense recorded notifications when transactions are logged
Notification cards now show amount and time on the right side opposite the title
Removed progress bar from notification cards
Email alerts toggle in settings now shows as "Coming Soon" and is disabled
Passport Checklist
"Set a savings goal" now checks real goal data from the database
"Chat with AI Coach" replaced with "Add both income and expense" — checks if user has logged at least one income and one expense transaction
"Log 10 transactions" now checks real transaction count from the database
"Reach your first goal" now checks for an actual completed goal in the database
"Maintain a budget for 30 days" left unchanged
Goals Page
Days remaining text hidden on completed goals
Removed "X active goals" summary text from top of page
Added All / Active / Done filter tabs — Active shows ongoing and overdue, Done shows completed goals only
Transactions Page
Income amounts now display in green
Expense amounts now display in red
Testing
Backend build passing ✅
Frontend lint fails only on pre-existing unrelated issues in SpendingChart.tsx, antigravity.tsx, and chatStore.ts — unrelated to this PR